Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate in creator being handled out of scope #290

Open
etj opened this issue May 5, 2022 · 1 comment
Open

Investigate in creator being handled out of scope #290

etj opened this issue May 5, 2022 · 1 comment
Assignees
Labels

Comments

@etj
Copy link
Member

etj commented May 5, 2022

creator fields are handled in an _alternate_id method that should not be intended to manipulate them

def _alternate_id(self, dataset_ref, alt_id):
out = {}
identifier = self.g.value(alt_id, SKOS.notation)
if not identifier:
return out
out['identifier'] = str(identifier)
predicate, basekey = DCT.creator, 'creator'
agent_dict, agent_loc_dict = self._parse_agent(alt_id, predicate, basekey)
agent = {}
for k, v in agent_dict.items():
new_k = 'agent_{}'.format(k[len(basekey) + 1:])
agent[new_k] = v
out['agent'] = agent
if agent_loc_dict.get('creator_name'):
out['agent']['agent_name'] = agent_loc_dict['creator_name']
return out

Move the creator logic where it belong.

@etj etj self-assigned this May 5, 2022
@etj
Copy link
Member Author

etj commented May 5, 2022

The method is looking for a DCT.creator in the alternate identifier node.

Current dcatapit doc does not mention it.

Anyway adms:Identifier definition does refer to creator:

 <http://www.w3.org/ns/adms#Identifier> dcterms:identifier "adms:Identifier";
 	a rdfs:Class;
 	rdfs:comment "This class is based on the UN/CEFACT Identifier complex type defined in See Section 5.8 of Core Components Data Type Catalogue Version 3.1 (http://www.unece.org/fileadmin/DAM/cefact/codesfortrade/CCTS/CCTS-DTCatalogueVersion3p1.pdf) In RDF this is expressed using the following properties: 
           - the content string should be provided using skos:notation, datatyped with the identifier scheme (inclduing the version number if appropriate); 
           - use dcterms:creator to link to a class describing the agency that manages the identifier scheme or adms:schemaAgency to provide the name as a literal. Although not part of the ADMS conceptual model, it may be useful to provide further properties to the Identifier class such as dcterms:created to provide the date on which the identifier was issued."^^rdf:XMLLiteral;
 	rdfs:isDefinedBy <http://www.w3.org/TR/vocab-adms>;
 	rdfs:label "Identifier"@en.

but its use is not enforced nor recommended nor suggested by AgID.

Remove that code at next cleanup.

@etj etj added the P: Low label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant