Compile error on ubuntu-19.04

[minjinhan]

Problem description

Doesn't compile.

src/extended/gff3_escaping.c: In function ‘gt_gff3_escaping_unit_test’:
src/extended/gff3_escaping.c:196:35: error: ‘__builtin___snprintf_chk’ output may be truncated before the last format character [-Werror=format-truncation=]
snprintf(code, 10, "foo%%%Xbar", i);
^
In file included from /usr/include/stdio.h:867,
from /home/hanmj/Bioinfo/TEs_identification/genometools-1.5.9/src/core/assert_api.h:21,
from /home/genometools-1.5.9/src/core/error_api.h:23,
from /home/genometools-1.5.9/src/core/error.h:21,
from /home/genometools-1.5.9/src/core/ensure.h:23,
from src/extended/gff3_escaping.c:21:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 10 and 11 bytes into a destination of size 10
return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:811: obj/src/extended/gff3_escaping.o] Error 1

Exact command line call triggering the problem

make

What GenomeTools version are you reporting an issue for (as output by gt -version)?

genometools-1.5.9

Did you compile GenomeTools from source? If so, please state the make parameters used.

yes

What operating system (e.g. Ubuntu, Mac OS X), OS version (e.g. 15.10, 10.11) and platform (e.g. x86_64) are you using?

Ubuntu-19.04
gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
GNU Make 4.2.1
Built for x86_64-pc-linux-gnu

[satta]

Could you probably try the latest released version of GenomeTools, 1.6.1? 1.5.9 is almost 4 years old... Please get it here from GitHub: https://github.com/genometools/genometools/archive/v1.6.1.zip

Unfortunately Ubuntu 19.04 does not seem to be supported anymore, so it's difficult to reproduce your build issue.

Edit: We have also updated the distributions (binary and source) on genometools.org: http://genometools.org/pub/ so they now carry the latest versions.

[satta]

AFAICS this has been fixed in #857, which is in 1.5.10 and later. See https://github.com/genometools/genometools/pull/857/files#diff-9b16bcfc1e73e4289777123dbb219c04L181