Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived_from not checked #909

Open
nathanhaigh opened this issue Feb 22, 2019 · 1 comment
Open

Derived_from not checked #909

nathanhaigh opened this issue Feb 22, 2019 · 1 comment

Comments

@nathanhaigh
Copy link

TAIR10 GFF file (ftp://ftp.arabidopsis.org/home/tair/Genes/TAIR10_genome_release/TAIR10_gff3/TAIR10_GFF3_genes.gff) contains the attribute Derived_from which references ransposable element features not defined in the GFF file.

I think that gt gff3 should throw an error (perhaps only when -checkids is specified) in such situations. In addition, perhaps gt gff3validator should throw an error?

curl ftp://ftp.arabidopsis.org/home/tair/Genes/TAIR10_genome_release/TAIR10_gff3/TAIR10_GFF3_genes.gff \
| sed '1i ##gff-version 3' \
| sed -r 's/Index/index/g' \
| gt gff3 -retainids \
| git_repos/gff3sort/gff3sort.pl /dev/stdin \
| bgzip \
> TAIR10_GFF3_genes.gff3.gz
gt gff3validator TAIR10_GFF3_genes.gff3.gz
@gordon
Copy link
Member

gordon commented Feb 27, 2019

Although this requirement (Derives_from references should exist) is not explicitly mentioned in the GFF3 it would make sense to add this check.

I think the best solution would be to add a -checkderivesfrom option to gt gff3 and gt gff3validator which implies -checkids.

Any volunteers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants