Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-lmm 9 option leads to bug in mvlmm model #255

Open
diogro opened this issue Aug 30, 2021 · 1 comment
Open

-lmm 9 option leads to bug in mvlmm model #255

diogro opened this issue Aug 30, 2021 · 1 comment
Assignees

Comments

@diogro
Copy link

diogro commented Aug 30, 2021

The mvlmm file is missing the case for the -lmm 9 option, leading to an output file with a single line and no significance values.

GEMMA/src/mvlmm.cpp

Lines 192 to 202 in 5caf948

if (a_mode == 1) {
outfile << sumStat[t].p_wald << endl;
} else if (a_mode == 2) {
outfile << sumStat[t].p_lrt << endl;
} else if (a_mode == 3) {
outfile << sumStat[t].p_score << endl;
} else if (a_mode == 4) {
outfile << sumStat[t].p_wald << "\t" << sumStat[t].p_lrt << "\t"
<< sumStat[t].p_score << endl;
} else {
}

I stumbled on this because I'm also experiencing the long run times referenced in issue #243 when using -lmm 1. Option 9 runs, but with the mangled output.

@pjotrp
Copy link
Member

pjotrp commented Sep 22, 2021

Thanks for reporting!

@pjotrp pjotrp self-assigned this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants