Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests,util-docker,github: Add Ubuntu 24.04 Docker image & updated tests/actions to use it #1018

Merged
merged 4 commits into from
Apr 15, 2024
Merged

tests,util-docker,github: Add Ubuntu 24.04 Docker image & updated tests/actions to use it #1018

merged 4 commits into from
Apr 15, 2024

Conversation

BobbyRBruce
Copy link
Member

This ensures gem5 compiles and runs in 24.04 environments. A necessary PR, for ensuring gem5 support Ubuntu 24.04 (related issue: #909)

@BobbyRBruce
util-docker: Add ubuntu-24.04_all-deps Docker
3962fca 
Change-Id: I5917c446cacc25d1a333b5cf8147ee78b112aeb3
@BobbyRBruce
util-docker: Add Ubuntu 24.04 min-dep Docker
d091c64 
Change-Id: Ia5cb4f2fd54ce53494ab95705b4f6006648d7eba
@BobbyRBruce
misc: Update Update GitHub Actions to use 24.04 over 22.04
05bc85a 
This change ensures all our tests run on our most recent supported LTS
release of Ubuntu.

In the case of compiler tests we still test 22.04 all-dep but test 24.04
all-dep and min-dep (i.e., we drop 22.04 min-dep as it's somewhat
redundant).

Change-Id: I63666d1017594b496523a48e5112a8994f57885f
@BobbyRBruce
util-docker: Remove 22.04 min-dep Dockerfile
ccd9beb 
We only test the latest LTS Ubuntu release with min-deps. With 24.04, we
no longer require the 22.04 min dependencies image.

Change-Id: I4b3d668c1f9d10c2b6071848e6daada6c763b5e7
@BobbyRBruce BobbyRBruce added tests gem5's Testing Infrastructure util-docker Docker util files. That found in "utils/docker" github gem5 files necessary for GitHub integration. Found in ".github" labels Apr 13, 2024
@BobbyRBruce BobbyRBruce linked an issue Apr 13, 2024 that may be closed by this pull request
Test support for Ubuntu 24.04 #909
Open
@BobbyRBruce BobbyRBruce mentioned this pull request Apr 14, 2024
Open
ivanaamit
ivanaamit approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@ivanaamit ivanaamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BobbyRBruce BobbyRBruce merged commit 56a2346 into gem5:develop Apr 15, 2024
36 checks passed
@BobbyRBruce BobbyRBruce deleted the tests-to-use-24-04-by-default branch April 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanaamit ivanaamit ivanaamit approved these changes

Assignees
No one assigned
Labels
github gem5 files necessary for GitHub integration. Found in ".github" tests gem5's Testing Infrastructure util-docker Docker util files. That found in "utils/docker"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test support for Ubuntu 24.04
2 participants
@BobbyRBruce @ivanaamit