Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI String Improvements #914

Merged
merged 2 commits into from
Jun 1, 2024
Merged

UI String Improvements #914

merged 2 commits into from
Jun 1, 2024

Conversation

yakushabb
Copy link
Contributor

ui: Improve remove strings

Change the 'Remove from library' strings to 'Permanently delete' to make the action clearer for the user, informing them that the action will delete user files and cannot be undone.

Fixes #912

ui: Make some strings GNOME HIG compatible

Use header capitalization for menu entries and titles.

More information: https://developer.gnome.org/hig/guidelines/writing-style.html

Change the 'Remove from library' strings to 'Permanently delete'
to make the action clearer for the user, informing them that the
action will delete user files and cannot be recovered.

Fixes geigi#912
Use header capitalization for menu entries and titles.

More information: https://developer.gnome.org/hig/guidelines/writing-style.html
@yakushabb yakushabb changed the title Draft: UI String Improvements UI String Improvements Apr 27, 2024
@rdbende
Copy link
Collaborator

rdbende commented Jun 1, 2024

I'll merge this, but keep #912 open, as I think it would be still better to have not remove them, and have a blacklist instead.

@rdbende rdbende merged commit 477c0f6 into geigi:master Jun 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not delete user files!
2 participants