Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a Block Name Doesn't Immediately Update the Types of Part Properties #2852

Open
1 of 3 tasks
danyeaw opened this issue Nov 19, 2023 · 5 comments
Open
1 of 3 tasks
Labels
bug An issue in the application

Comments

@danyeaw
Copy link
Member

danyeaw commented Nov 19, 2023

Describe the bug

The Part Property type of a Block isn't immediately updated when you rename the Block.

image

To Reproduce

Steps to reproduce the behavior:

  1. Create a block called Car
  2. Create a 2nd block named Wheel
  3. Add a composition relationship from the Car to the Wheel
  4. Rename the Car to SUV
  5. Notice that the type of the Part Property still says Car

Expected behavior

The Part Property type is updated immediately

Screenshots

If applicable, add screenshots to help explain your problem.

OS

  • Linux (Please put in notes the specific distro)
  • macOS
  • Windows

Version

Version of Gaphor: latest main

Additional information

Add any other context about the problem here.

@danyeaw danyeaw added bug An issue in the application first-timers-only This makes an excellent first contribution labels Nov 19, 2023
@patilanuja
Copy link

@danyeaw Can you please assign this me.

@danyeaw
Copy link
Member Author

danyeaw commented Nov 19, 2023

Hi @patilanuja, thanks so much! Please let us know if you need any guidance.

@patilanuja
Copy link

@danyeaw Sure!

@amolenaar
Copy link
Member

This issue is not trivial. We use function to format the text in the model browser. It updates the text when the element changes, but it doesn't know which related objects (like property type in this case) should also trigger an update of the text.

@patilanuja
Copy link

@amolenaar Sorry, I got stuck in another work. For now, I will unassign myself from this issue.

@patilanuja patilanuja removed their assignment Nov 30, 2023
@danyeaw danyeaw removed the first-timers-only This makes an excellent first contribution label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

No branches or pull requests

3 participants