Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question | TWIG: Joomla Finder and Tags #2534

Closed
thexmanxyz opened this issue Sep 6, 2019 · 4 comments
Closed

Question | TWIG: Joomla Finder and Tags #2534

thexmanxyz opened this issue Sep 6, 2019 · 4 comments
Labels
Milestone

Comments

@thexmanxyz
Copy link
Contributor

thexmanxyz commented Sep 6, 2019

@yellowwebmonkey @mahagr @newkind

Is there a way to filter Joomla articles with the joomla.finder() by tag or alternatively return the tags with the article object? By default the objects returned do not contain the tags as array / attribute, checked with dump(...). However there is a field ["show_tags"]=> string(0) "". I tried messing with that field as an option parameter but that didn't work. Some hint would be highly appreciated. Thanks!

I added a screenshot to show what field within a Joomla article I mean / target.

grafik

@mahagr
Copy link
Member

mahagr commented Oct 1, 2019

Unfortunately, tags are not supported by the finder.

@mahagr mahagr added the question label Oct 1, 2019
@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Oct 2, 2019

@mahagr @yellowwebmonkey Are there any plans to implement this feature within the finder or is there a possibility to see this coming at some point in the future? Because there is a demand to fetch articles by their tags.

It would be great to at least have the option to fetch them by a method like:
finder.tags(tags, match_all = true).

.tags(['tag-a','tab-b','tag-c'], false) ... it would be useful to have a second parameter which defines whether all tags (true) should be matched or any of the passed tags (false).

@mahagr
Copy link
Member

mahagr commented Oct 2, 2019

There is a feature request for this: #1631

I would love to implement this soon, but for me getting Joomla 4 support and menu fixes done are more important at this moment.

If someone likes to look into this (mostly if there's a way to use Joomla tags by some API), I would love to hear about it.

@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Nov 28, 2019

@mahagr I completely missed the #1631 feature request. In the meantime we have a working PR for this FR so I will close this issue because it is not needed any more and everything discussed / outlined here should be working with #2561 (a very solid approach that just waits to be merged into develop :P).

@mahagr mahagr added this to the 5.4.36 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants