Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists not working in some browsers #139

Open
stevekrouse opened this issue Sep 8, 2021 · 5 comments
Open

Lists not working in some browsers #139

stevekrouse opened this issue Sep 8, 2021 · 5 comments

Comments

@stevekrouse
Copy link
Contributor

While it works in Chrome on my Linux machine, it does not work on Chrome on mobile or Firebox or Chromium on Linux.

import { runComponent, elements as E } from "@funkia/turbine";

// Also fails: runComponent("#mount", E.div(["hi"]));
runComponent("#mount", ["hi"]);

Codesandbox: https://codesandbox.io/s/determined-water-oqv6o?file=/src/index.ts

Error:

Screenshot from 2021-09-08 11-42-08

@stevekrouse
Copy link
Contributor Author

The problem happens on the codesandboxes in the readme on mobile. For example: https://codesandbox.io/s/xenodochial-williams-xok6q

@limemloh
Copy link
Member

limemloh commented Sep 9, 2021

The issue is related to a bug in isBehavior from hareactive.
See funkia/hareactive#97.

My guess why it still works on your linux machine, is because the chrome version is older than 92, where they introduced a new method on arrays which causes the issue.

@stevekrouse
Copy link
Contributor Author

Ah amazing! Glad you have a fix almost ready. When do you expect it to land? Or do you have a suggested workaround?

@stevekrouse
Copy link
Contributor Author

I'm working on getting a development environment setup so I can make this fix myself but I'm unable to find a way to get npm to use my local version of hareactive/turbine instead of that from the npm registry. Am I missing a build step or something?

Ideally, I want it to auto-reload changes from these dependencies on save, if possible. How do you advise a setting up development environment for hacking on hareactive and turbine?

For context, I'm working on gitpod.io instead of locally -- if that helps. (Easier to collaborate)

@stevekrouse
Copy link
Contributor Author

After a 2 hours I was able to get local dependencies working! The issue was that I was on node v14.18.3 which seems to require turbine/node_modules/hareactive/dom/package.json to exist, which it does in the npm package but not when you build it locally. I was able to fix the issue by either downgrading node to v12.18.3 or by adding that file to the symlinked hareactive directory. This should probably be its own github issue under hareactive or turbine (if it isn't already), yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants