Linkability is broken in the lite branch

[LOuroboros]

Title.
Tested using VBA 1.7.2.
Linkability in the Master branch works just fine.
I'm guessing this is a result of removing wireless connection related code and other things from the lite branch.
I'm opening this Issue ticket because I'm not fully sure if linking is supposed to be broken in that branch or not.

pn_2506.mp4

Here's the .sa1 and .sa2 files to load up in VBA 1.7.2 (File -> Import -> Battery File):
em20xx_lite.zip

[froggestspirit]

Please see if the glitch exists in MGBA, VBA id known to not work as reliably

…

On Thu, Dec 2, 2021, 2:08 PM LOuroboros ***@***.***> wrote: Title. Tested using VBA 1.7.2. Linkability in the Master branch works just fine. I'm guessing this is a result of removing wireless connection related code and other things from the lite branch. I'm opening this Issue ticket because I'm not fully sure if linking is supposed to be broken in that branch or not. https://user-images.githubusercontent.com/4485172/144486602-de14011c-8b28-48a3-b5f4-97d7dd37ae67.mp4 Here's the .sa1 and .sa2 files to load up in VBA 1.7.2 *(File -> Import -> Battery File)*: em20xx_lite.zip <https://github.com/froggestspirit/Emerald20XX/files/7644477/em20xx_lite.zip> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2OD36AYZT372QZH62Y4LDUO67ZRANCNFSM5JH4NDQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[froggestspirit]

Though it might be an issue with the lite branch if master is working...

…

On Thu, Dec 2, 2021, 2:09 PM Alec Lafleur ***@***.***> wrote: Please see if the glitch exists in MGBA, VBA id known to not work as reliably On Thu, Dec 2, 2021, 2:08 PM LOuroboros ***@***.***> wrote: > Title. > Tested using VBA 1.7.2. > Linkability in the Master branch works just fine. > I'm guessing this is a result of removing wireless connection related > code and other things from the lite branch. > I'm opening this Issue ticket because I'm not fully sure if linking is > supposed to be broken in that branch or not. > > > https://user-images.githubusercontent.com/4485172/144486602-de14011c-8b28-48a3-b5f4-97d7dd37ae67.mp4 > > Here's the .sa1 and .sa2 files to load up in VBA 1.7.2 *(File -> Import > -> Battery File)*: > em20xx_lite.zip > <https://github.com/froggestspirit/Emerald20XX/files/7644477/em20xx_lite.zip> > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#14>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA2OD36AYZT372QZH62Y4LDUO67ZRANCNFSM5JH4NDQQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

[LOuroboros]

Please see if the glitch exists in MGBA, VBA id known to not work as

Yeah, I'm aware. It's just that I never really tested linking on mGBA before. Oh well, there's a first time for everything.

I'll edit in a couple of minutes with the results.

[froggestspirit]

Sorry about that, i saw VBA and kind of jumped the gun a little

…

On Thu, Dec 2, 2021, 2:12 PM LOuroboros ***@***.***> wrote: Please see if the glitch exists in MGBA, VBA id known to not work as Yeah, I'm aware. It's just that I never really tested linking on mGBA before. Oh well, there's a first time for everything. I'll edit in a couple of minutes with the results. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2OD36BJVEJYZT4LCOSW3LUO7AIHANCNFSM5JH4NDQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[LOuroboros]

I'll be completely honest, I'm not sure if mGBA's linking capabilities are even working at all, like, officially? 😂 ...

It gets stuck on "Please wait." so it's not working regardless, but I can't tell if mGBA is the one to blame in this situation, or not.

pn2509.mp4

[froggestspirit]

Its completely possible i broke it lol. Hard to tell sometimes what can stay or go. I dont think the lite branch provides significant advantages over master, so it might be better to use that for the time being

…

On Thu, Dec 2, 2021, 2:54 PM LOuroboros ***@***.***> wrote: I'll be completely honest, I'm not sure if mGBA's linking capabilities are even working at all, like, officially? 😂 ... It gets stuck on "Please wait." so it's not working regardless, but I can't tell if mGBA is the one to blame in this situation, or not. https://user-images.githubusercontent.com/4485172/144493160-45b2740e-9a7a-4950-b941-79fedc28b236.mp4 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2OD34DLNR5VCXYZWROGZLUO7FHHANCNFSM5JH4NDQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[LOuroboros]

Alright, I got it.

It doesn't work.

If you try to trade between 2 different savefiles, you get the same error that VBA Link gives.

If you try to trade between 1 same savefile, you can get a bit further, but an error kills the connection just before starting a trade.

2514.mp4

2511.mp4

EDIT:

I dont think the lite branch provides significant advantages
over master, so it might be better to use that for the time being

Actually, I'm manually porting stuff over to my project. I'm not using it as a base 😅

I'm guessing the removal of the wireless connection or some of its components is what could have caused this problem?

I'll do some tests to try to find out.