Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dehacked Cheats result in warning in chocolate #750

Open
Catoptromancy opened this issue Jul 28, 2021 · 3 comments
Open

Dehacked Cheats result in warning in chocolate #750

Catoptromancy opened this issue Jul 28, 2021 · 3 comments
Labels
bug Dehacked Related to DEH file.

Comments

@Catoptromancy
Copy link
Contributor

Catoptromancy commented Jul 28, 2021

Not sure this is really worth it, if chocolate complains. It is not even making freedoom specific codes, just swapping the originals for some reason.

Chocolate-doom message:

DEHACKED:535: warning: Cheat sequence longer than supported by Vanilla dehacked

Freedoom's dehacked.txt:

Redefine the no-clipping cheats, so that IDCLIP may be used in Phase 1.
IDSPISPOPD is swapped into the slot normally for Phase 2, in case of
engines that would otherwise try to apply the cheat twice.

Cheat 0
No Clipping 1 = idclip
No Clipping 2 = idspispopd

@Xindage Xindage added the Dehacked Related to DEH file. label Jun 24, 2023
@mc776
Copy link
Contributor

mc776 commented Jul 9, 2023

on the one hand it would be nice to clean this up.

on the other please don't ever make me type idspospispospppsd again.

@mc776 mc776 changed the title Dehacked Cheats Dehacked Cheats result in warning in chocolate Jul 9, 2023
@mc776 mc776 added the bug label Jul 11, 2023
@mc776
Copy link
Contributor

mc776 commented Jul 11, 2023

If I reduce the spispopd cheat to the same length as idclip the warning message goes away:

Cheat 0
No Clipping 1 = idclip
No Clipping 2 = idspis

Do the engines that might apply the cheat twice even care what the second item actually says? If not then this could be a solution.

@mc776
Copy link
Contributor

mc776 commented Dec 12, 2023

If I reduce the spispopd cheat to the same length as idclip the warning message goes away:

Cheat 0
No Clipping 1 = idclip
No Clipping 2 = idspis

For what it's worth, I've had this solution in my personal fork for quite some time and it's never caused me any problems, but I've only really used it with chocolate and GZ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dehacked Related to DEH file.
Projects
None yet
Development

No branches or pull requests

3 participants