Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: increase contrast of RW18_1 and 2. #1339

Closed
wants to merge 3 commits into from
Closed

patches: increase contrast of RW18_1 and 2. #1339

wants to merge 3 commits into from

Conversation

mc776
Copy link
Contributor

@mc776 mc776 commented Feb 14, 2024

Closes #1334.

@mc776 mc776 added the patches label Feb 14, 2024
@KorpKat
Copy link
Contributor

KorpKat commented Feb 22, 2024

Im unsure about the amount of contrast, it makes some of the shading to look really rough, could you show pictures of the edited picture in-game?

@Talon1024
Copy link
Contributor

There's a screenshot in the issue.

@Anonysussy
Copy link
Contributor

Anonysussy commented Feb 23, 2024

While I'm still at it, here's a slightly cleaned up version of RW18_2 I've worked on.
rw18_2
The other one I did which lighten the color black a bit so it doesn't stick out too much.
rw18_2

@mc776
Copy link
Contributor Author

mc776 commented Feb 23, 2024

Before and after. (Using the first one - lightening the back is going to reintroduce the problem this was intended to solve)
DOOM00
DOOM01

DOOM03
DOOM02

@mc776
Copy link
Contributor Author

mc776 commented Feb 23, 2024

The lighter one for comparison - it's not too apparent from the static shot but as you move towards it the darkest parts go from black to grey in a way that makes you wonder if there's something wrong with your gamma:
DOOM01
DOOM00

@mc776
Copy link
Contributor Author

mc776 commented Feb 23, 2024

the darkest parts go from black to grey in a way that makes you wonder if there's something wrong with your gamma

The issue for me is that these parts were completely black and if they're pure black they stay black, but when they're dark grey and lighten up as you approach you still see the solid non-black but it's all a flat colour with no additional detail visible.

Here's an attempt to add more detail inside those cracks:
DOOM01
DOOM00
rw18_2

@Anonysussy
Copy link
Contributor

the darkest parts go from black to grey in a way that makes you wonder if there's something wrong with your gamma

The issue for me is that these parts were completely black and if they're pure black they stay black, but when they're dark grey and lighten up as you approach you still see the solid non-black but it's all a flat colour with no additional detail visible.

Here's an attempt to add more detail inside those cracks: DOOM01 DOOM00 rw18_2

This one looks better, I would like this to be committed

@mc776
Copy link
Contributor Author

mc776 commented Mar 3, 2024

This one looks better, I would like this to be committed

I did this shortly after this comment, so unless something seriously went wrong with the upload that I can't see I think this should be ready.

@mc776 mc776 closed this by deleting the head repository Mar 4, 2024
@unithecutie
Copy link
Contributor

mc776 closed this by deleting the head repository

Huh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

patches: consider increasing contrast of RW18_1 and 2.
6 participants