Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: pneumatic testbed setup deprecated #8608

Open
tracernz opened this issue Apr 4, 2024 · 5 comments
Open

rust: pneumatic testbed setup deprecated #8608

tracernz opened this issue Apr 4, 2024 · 5 comments
Labels
Request New feature or request

Comments

@tracernz
Copy link
Member

tracernz commented Apr 4, 2024

Aircraft Version

Development

Description

Needs setup to use the new method. Good first issue for rust enthusiasts.

warning: use of deprecated associated function `simulation::update_context::UpdateContext::new`: Do not create UpdateContext directly. Instead use the SimulationTestBed or your own custom test bed.
   --> fbw-common/src/wasm/systems/systems/src/pneumatic/valve.rs:671:24
    |
671 |         UpdateContext::new(
    |                        ^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: use of deprecated associated function `simulation::update_context::UpdateContext::new`: Do not create UpdateContext directly. Instead use the SimulationTestBed or your own custom test bed.
    --> fbw-common/src/wasm/systems/systems/src/pneumatic/mod.rs:1038:24
     |
1038 |         UpdateContext::new(
     |                        ^^^

References (optional)

No response

Additional info (optional)

No response

Discord Username (optional)

No response

@tracernz tracernz added Request New feature or request Good First Issue Good for newcomers labels Apr 4, 2024
@Aditya13s
Copy link

Please assign me I am working on it. @tracernz

@tracernz tracernz assigned tracernz and Aditya13s and unassigned tracernz Apr 12, 2024
@Aditya13s
Copy link

@tracernz can you tell me what I need to do in it?

@2hwk
Copy link
Member

2hwk commented Apr 17, 2024

See some other examples in hydraulic, air conditioning test.rs etc. It's what the warning states, for unit testing, use SimulationTestBed test_bed vs UpdateContext

EDIT: Note that if this is still unclear to you, it may be better to leave this to somebody else with more experience with rs as its important that the unit tests that these cover still work (and test) correctly after the refactor.

@tracernz
Copy link
Member Author

@tracernz can you tell me what I need to do in it?

Not sure, that's why I didn't do it. ;)

@tracernz
Copy link
Member Author

Do note that this is a good first issue for somebody already familiar with rust; not for a novice rust programmer.

@2hwk 2hwk removed the Good First Issue Good for newcomers label May 2, 2024
@Aditya13s Aditya13s removed their assignment May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants