Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace directories should not change by navigating between folders #1014

Open
MariusAlbrecht opened this issue Feb 12, 2024 · 5 comments
Open
Labels
needs-discussion This change requires some more discussion before we decide we definitely want it UI / UX Design, UI and UX issues

Comments

@MariusAlbrecht
Copy link

Describe the bug
When navigating inside a workspace, that is double clicking a directory or using the "Move dir up" button the actual root directory of a workspace changes.

To Reproduce
Steps to reproduce the behavior:

  1. create workspace at location <somepath>/x/
  2. navigate to <somepath>/x/y/ or <somepath>/
  3. click "Edit selected workspace"
  4. see changed workspace location

Expected behavior
The root directory should stay the same, only the displayed directory should change. In particular should the same root dir be displayed at every startup regardless of navigation in earlier sessions.
The root dir should be changeable (only) by using the "Edit [selected] workspace" menu.

Additional context
n/a

@Doublonmousse
Copy link
Contributor

Should a "reset" button be added to reset these workspace to their original folder ?

Seeing that the directory changed from the original workspace folder should be visible too (maybe a dot notation to show changes from the initial change)

I feel like some of the workspace design has to change to accomodate this change. At the moment the current behavior matches the design and stopping at just changing when the workspace directory changes would be confusing without these two extra pointers to understand the new behavior

@MariusAlbrecht
Copy link
Author

MariusAlbrecht commented Feb 13, 2024

that'd certainly be a possibility.
For me personally things would work as expected if everything stayed as is now (especially current navigation and ui) except for the fact that workspaces lose their "navigation state" when the app is closed.
This means upon startup it'd be at the root location again.
I can absolutely see a case for a more explicit solution, too. My version works for my intuition, and I can't really guess it'd work for others as well

edit: just to try and clarify:
I think the workspace location and "navigation state" are entirely different things. That's why I reported them getting mixed up as a bug. This way your suggested dot notation seems unintuitive (at least on first glance, I'll gladly compromise or be convinced otherwise)

@flxzt flxzt added UI / UX Design, UI and UX issues needs-discussion This change requires some more discussion before we decide we definitely want it labels Feb 16, 2024
@Doublonmousse
Copy link
Contributor

Yeah on second thought the dot thing is probably not a good idea.

Just a single button to reset the view back to the root folder of the workspace is probably more than enough to convey the new behavior and make it easier to reset things back to the initial state of the workspace directory if needed

@KelvinNovais
Copy link

I agree with the author, it doesn't make sense to have a workspace root directory that keeps moving.

Some people pointed about a "reset button", that in my opinion is the workspace button itself: whenever you click it, you go to the workspace you have set.

@Doublonmousse
Copy link
Contributor

Oh that's a neat solution.

Well I'm all for it then (use the workspace button to reset the view).
I don't have any disagreement left with that proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion This change requires some more discussion before we decide we definitely want it UI / UX Design, UI and UX issues
Projects
None yet
Development

No branches or pull requests

4 participants