Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log message: resource expiration updated from 0.00 to 0.00 (-inf) #5973

Closed
garlick opened this issue May 16, 2024 · 1 comment · Fixed by #6016
Closed

log message: resource expiration updated from 0.00 to 0.00 (-inf) #5973

garlick opened this issue May 16, 2024 · 1 comment · Fixed by #6016

Comments

@garlick
Copy link
Member

garlick commented May 16, 2024

These log messages are a bit inappropriate if nothing changed when the config is reloaded:

[snip]
[ +24.019297] broker[0]: configuration updated
[snip]
[ +25.263513] job-manager[0]: duration-validator: updated expiration to 0.00
[ +25.263667] job-manager[0]: resource expiration updated from 0.00 to 0.00 (-inf)
@grondo
Copy link
Contributor

grondo commented May 16, 2024

Oh, these occur in spots that are watching resource.R for potential updates of resource expiration. Makes sense in each case to check if the value changed (though these are LOG_DEBUG level messages)

grondo added a commit to grondo/flux-core that referenced this issue May 29, 2024
@grondo
job-manager: don't log expiration update when unnecessary
2db17d0 
Problem: The job manager update handler and validate-duration plugin
log messages about expiration updates when the resources set changes
but the expiration doesn't.

Only log updates when there's a change in expiration.

Fixes flux-framework#5973
@grondo grondo mentioned this issue May 30, 2024
Merged
@mergify mergify bot closed this as completed in #6016 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

job-manager: don't log expiration update when unnecessary grondo/flux-core
2 participants
@garlick @grondo