Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] EmbedderSurfaceMetal must be renamed to EmbedderSurfaceMetalSkia #148235

Closed
chinmaygarde opened this issue May 13, 2024 · 0 comments · Fixed by flutter/engine#52855
Closed

[Impeller] EmbedderSurfaceMetal must be renamed to EmbedderSurfaceMetalSkia #148235

chinmaygarde opened this issue May 13, 2024 · 0 comments · Fixed by flutter/engine#52855
Labels
c: tech-debt Technical debt, code quality, testing, etc. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@chinmaygarde
Copy link
Member

There is already a EmbedderSurfaceMetalImpeller for Impeller but the Skia variant was not renamed.

No change in functionality is expected.
@chinmaygarde chinmaygarde added c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels May 13, 2024
@jonahwilliams jonahwilliams added P3 Issues that are less important to the Flutter project triaged-engine Triaged by Engine team labels May 13, 2024
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue May 15, 2024
@chinmaygarde
Rename Skia specific TUs.
8da42e9 
Fixes flutter/flutter#148235
@chinmaygarde chinmaygarde mentioned this issue May 15, 2024
Merged
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue May 23, 2024
@chinmaygarde
Rename Skia specific TUs.
4aa2f19 
Fixes flutter/flutter#148235
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue May 24, 2024
@chinmaygarde
Rename Skia specific TUs.
0755e17 
Fixes flutter/flutter#148235
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 24, 2024
@chinmaygarde
Rename Skia specific TUs. (#52855)
1135556 
Fixes flutter/flutter#148235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Skia specific TUs. chinmaygarde/flutter_engine
2 participants
@chinmaygarde @jonahwilliams