AssertionScope w/explicit name AND DetermineCallerIdentity

[fuzzykiller]

Sometimes, I'd like to provide human-readable context for a particular block of assertions. This however means that FluentAssertions no longer does its automatic assertion subject check. So instead of...

Expected instruction.Hidden not to be False, but found False.

I then get

Expected Instruction 3 not to be False, but found False.

That's not terribly helpful in my opinion. I can no longer see the property being checked. I'd like to have both: Explicitly provided scope name AND the automatic subject detection. Or maybe even, generally, a way for the resulting context name to be made up of all the nested (named) scopes along the way.

I see that AssertionScope is currently being redesigned, so maybe this here is a possible future improvement?

[dennisdoomen]

Isn't that what #2607 fixes?

[fuzzykiller]

Unfortunately not, the “problematic” behavior is unchanged. As soon as one explicitly named context is in play, DetermineCallerIdentity is no longer used.

using var scope1 = new AssertionScope("Test1");
using var scope2 = new AssertionScope("Test2");
nonEmptyList.Should().BeEmpty();

means I get:

Expected Test1/Test2 to be empty, but found at least one item {"Hello"}.

Previously, “Test1” wouldn’t have been mentioned, but even now I still don’t see what exactly what checked inside that scope.

[dennisdoomen]

Ah, you are expecting something like `Did not expect test1/tests/nonEmptyList to be empty"?

[fuzzykiller]

Yes, exactly!