Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gui-client): Bubble panics from connlib in the IPC service to error dialogs in the GUI #5046

Closed
ReactorScram opened this issue May 20, 2024 · 1 comment · Fixed by #5098
Closed

chore(gui-client): Bubble panics from connlib in the IPC service to error dialogs in the GUI #5046

ReactorScram opened this issue May 20, 2024 · 1 comment · Fixed by #5098
Assignees
@ReactorScram
Labels
area/tauri_client The Windows and Linux Tauri GUI clients needs triage Issues opened by the public or need further labeling

Comments

@ReactorScram
Copy link
Collaborator

ReactorScram commented May 20, 2024 •
edited

Refs #5027, the leading hypothesis is that DNS fails, then we panic, Tokio catches that panic, and we should at least log it in the IPC service's logs, but it would be even better to have the GUI show something to the user.
@ReactorScram ReactorScram added needs triage Issues opened by the public or need further labeling area/tauri_client The Windows and Linux Tauri GUI clients labels May 20, 2024
@ReactorScram ReactorScram self-assigned this May 20, 2024
@ReactorScram
Copy link
Collaborator Author

If we stringify them on the IPC service side this can work. The error types themselves are not serializable in general

@ReactorScram ReactorScram mentioned this issue May 22, 2024
Merged
@ReactorScram ReactorScram linked a pull request May 22, 2024 that will close this issue
chore(gui-client): Bubble up connlib panics as error dialogs in the GUI #5098
Merged
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@ReactorScram
chore(gui-client): Bubble up connlib panics as error dialogs in the G…
6408131 
…UI (#5098)

Closes #5046 

<img width="486" alt="image"
src="https://github.com/firezone/firezone/assets/13400041/303a1307-5e37-4fce-886c-2deb5bd36ba0">

---------

Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReactorScram ReactorScram

Labels
area/tauri_client The Windows and Linux Tauri GUI clients needs triage Issues opened by the public or need further labeling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(gui-client): Bubble up connlib panics as error dialogs in the GUI firezone/firezone
1 participant
@ReactorScram