Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, web): get auth credential from exception and pass to user if one is available #12780

Merged
merged 2 commits into from
May 20, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented May 14, 2024

Description

I tested this with user's example and it worked as intended. The JS error is correctly parsed and instantiated as a Dart credential if it exists. If not, null is passed as credential which is a nullable argument on FirebaseAuthException:

final AuthCredential? credential;

Related Issues

fixes #12771

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth, web): get auth credential from exception and pass to user fix(auth, web): get auth credential from exception and pass to user if one is available May 15, 2024
@mertguler94
Copy link

Waiting for this PR to be merged, thanks @russellwheatley .

@russellwheatley russellwheatley merged commit 39f6e7b into master May 20, 2024
25 checks passed
@russellwheatley russellwheatley deleted the auth-12771 branch May 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_auth]: error.credential is null on credential-already-in-use exception during apple sign in in web
5 participants