Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetDocuments: whereField creates a memory leak. #12613

Open
jorgefrazaocosta opened this issue Mar 22, 2024 · 5 comments · May be fixed by #12972
Open

GetDocuments: whereField creates a memory leak. #12613

jorgefrazaocosta opened this issue Mar 22, 2024 · 5 comments · May be fixed by #12972
Assignees
@milaGGL
Labels
api: firestore needs-attention

Comments

@jorgefrazaocosta
Copy link

jorgefrazaocosta commented Mar 22, 2024 •
edited

Description

Using Leaks, it's possible to see that when we use the whereField, there is a memory leak being created. We saw it in several and different calls, all of them the Leaks tool points to the whereField.

Reproducing the issue

  1. Adds Firebase Firestore to the project
  2. Read documents from a Collection and filter some results using the whereField method from FIRQuery
  3. Launch App
  4. Observe memory leak using Leaks tool

Firebase SDK Version

10.23.0

Xcode Version

15.3

Installation Method

Swift Package Manager

Firebase Product(s)

AB Testing, Analytics, Authentication, Crashlytics, Firestore, Remote Config

Targeted Platforms

iOS

Relevant Log Output

Screenshot 2024-03-22 at 15 03 40

No response

If using Swift Package Manager, the project's Package.resolved

No response

If using CocoaPods, the project's Podfile.lock

No response
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@tom-andersen
Copy link
Contributor

Thank you for the report. I will look into this as soon as possible.

@tom-andersen tom-andersen self-assigned this Mar 25, 2024
@tom-andersen
Copy link
Contributor

@jorgefrazaocosta Does this happen in version 10.15.0? We suspect maybe this might have been introduced in 10.16.0.

@jorgefrazaocosta
Copy link
Author

@tom-andersen Indeed. It doesn't happen in version 10.15.0; I can see it using 10.16.0.

@tom-andersen
Copy link
Contributor

I am assigning this issue to @milaGGL who is more familiar with this part of the code.

@tom-andersen tom-andersen assigned milaGGL and unassigned tom-andersen Mar 26, 2024
@MarkDuckworth MarkDuckworth mentioned this issue Apr 9, 2024
Closed
@milaGGL milaGGL linked a pull request May 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milaGGL milaGGL

Labels
api: firestore needs-attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: whereField creates a memory leak firebase/firebase-ios-sdk
4 participants
@jorgefrazaocosta @tom-andersen @google-oss-bot @milaGGL