Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Disconnected from GitHub after a while #15378

Closed
EDM115 opened this issue May 12, 2024 · 15 comments
Closed

BUG: Disconnected from GitHub after a while #15378

EDM115 opened this issue May 12, 2024 · 15 comments
Labels
bug Something isn't working 👀 needs-additional info Needs more information from the reporter

Comments

@EDM115
Copy link

EDM115 commented May 12, 2024

Description

There is an option on Settings -> Git which allows to connect to a GitHub account. However after a system restart, the connexion is gone.
Note that :

  • It works when I close and reopen the app. Only a system restart seems to cause the issue.
  • The settings "Open on Startup" and "Keep running in the background when closed" are both disabled

Steps To Reproduce

  1. Open Files
  2. Connect to GitHub
  3. Restart the system
  4. Open Files again
  5. Notice that it asks to connect again

Requirements

The connection should stay even after a system restart

Files Version

3.4.0.0

Windows Version

10.0.22635.3575 (Actually Windows 11 23H2 build 22635.3575)

Log File

debug.log

@EDM115 EDM115 added the bug Something isn't working 👀 label May 12, 2024
@yaira2
Copy link
Member

yaira2 commented May 12, 2024

The GitHub login info is saved in the Windows Credentials in Control Panel. Do you have anything setup on your device that would wipe that on a restart?

@yaira2 yaira2 added the needs-additional info Needs more information from the reporter label May 12, 2024
@EDM115
Copy link
Author

EDM115 commented May 13, 2024

image
well the token is indeed saved, at first I thought it was a refresh issue but nope, it's a common PAT

image
OG one, generated last week

image
and it have been generated when I connected back yesterday

I believe that when the token is created, the limit date is really small, thus forcing to either refresh it (if still within the time frame) or reconnect entirely if we're past it

@EDM115 EDM115 changed the title [BUG] Disconnected from GitHub after each system restart [BUG] Disconnected from GitHub after a while May 13, 2024
@yaira2
Copy link
Member

yaira2 commented May 13, 2024

I believe that when the token is created, the limit date is really small, thus forcing to either refresh it (if still within the time frame) or reconnect entirely if we're past it

I'm not sure, I've had the same token on my device for a couple of months. Maybe it's a Github setting?

@EDM115
Copy link
Author

EDM115 commented May 13, 2024

Maybe it's a Github setting?

I doubt, I'm using some tokens for more than 2 years now

@yaira2
Copy link
Member

yaira2 commented May 13, 2024

@heftymouse fyi

@yaira2 yaira2 changed the title [BUG] Disconnected from GitHub after a while BUG: Disconnected from GitHub after a while May 13, 2024
@heftymouse
Copy link
Contributor

@EDM115 just to confirm, after you restart, does it still show up in Windows' Credential Manager?

@EDM115
Copy link
Author

EDM115 commented May 14, 2024

well yes it shows up, but i believe it's time-related (not launching the app for 1 week)

@heftymouse
Copy link
Contributor

So if you open Files immediately after a restart it still works?

@EDM115
Copy link
Author

EDM115 commented May 14, 2024

yes

@heftymouse
Copy link
Contributor

Are you able to reliably reproduce it not working after some time?

@EDM115
Copy link
Author

EDM115 commented May 14, 2024

i'll tell you in one week :)

@EDM115
Copy link
Author

EDM115 commented May 22, 2024

seemed like a skill issue on my end

@EDM115 EDM115 closed this as completed May 22, 2024
@yaira2
Copy link
Member

yaira2 commented May 22, 2024

@EDM115 did you mean to close this issue?

@EDM115
Copy link
Author

EDM115 commented May 22, 2024

yes
I believe it's a 3rd party app like CCleaner which may have deleted it
not an issue with Files itself

@yaira2
Copy link
Member

yaira2 commented May 22, 2024

That's good to know, thanks for clearing this up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀 needs-additional info Needs more information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants