Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitrate for audio files on file explorer v/s files app are different, possibly because of the way it is calculated? #15333

Closed
benjaminfl721 opened this issue May 8, 2024 · 3 comments
Labels
bug Something isn't working 👀

Comments

@benjaminfl721
Copy link

Description

So i made a feature request about something similar to this a little while ago, which was implemented - about putting the bitrate for audio files in the details pane. I also mentioned something about how bitrate shows up differently in files app for some reason, slightly off, for example 320kbps in file explorer would show up as 312.5kbps in files app. As it was being worked on a developer commented a reason this might be happening: "From looking, that is most likely due to the calculation being done. 192000 / 1024 would be 187.5 and not 192. So, we could change this conversion to kilo-bits (kbps) instead of kilo-bytes (KBps)." This might not be a bug per-se but it would certainly make much more sense if it was calculated this way as opposed to the way it is in files app currently.

Steps To Reproduce

find an audio file, click on it and open details pane, and view the audio encoding bitrate section

Requirements

change the way bitrate is calculated

Files Version

3.4.0.0

Windows Version

10.0.22631.3527

Log File

debug.log

@benjaminfl721 benjaminfl721 added the bug Something isn't working 👀 label May 8, 2024
@Jay-o-Way
Copy link
Contributor

Two quick thoughts:

  • what if a file has a variable bitrate?
  • one should be aware of the difference between kilobytes and kibibytes, they are notorious for being used incorrectly and even sometimes mixed...

@benjaminfl721
Copy link
Author

NVM, it looks like this is fixed in the new files preview update

@yaira2
Copy link
Member

yaira2 commented May 14, 2024

@benjaminfl721 I don't think we changed anything in the preview version that would affect this. Please keep us informed if the issue returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀
Projects
None yet
Development

No branches or pull requests

3 participants