Bug: COMException in AppThemeModeService.SetAppThemeMode

[yaira2]

Description

System.Runtime.InteropServices.COMException

Steps To Reproduce

Unknown (presumably it's when changing a theme setting)

Requirements

• Add error handling to prevent this crash

Files Version

v3.4

Windows Version

WINDOWS 10.0.19045

Log File

WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
Files.App.Services
AppThemeModeService.SetAppThemeMode (Window window, AppWindowTitleBar titleBar, Nullable`1 rootTheme, Boolean callThemeModeChangedEvent)
Files.App.Services
AppThemeModeService.ApplyResources ()
Files.App.ViewModels.Settings
AppearanceViewModel.set_AppThemeBackgroundColor (String value)
Files.App.ViewModels.Settings
AppearanceViewModel.set_SelectedAppThemeResources (AppThemeResourceItem value)
ABI.Microsoft.UI.Xaml
DependencyPropertyChangedCallback.Do_Abi_Invoke (IntPtr thisPtr, IntPtr sender, IntPtr dp)
WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
ABI.Windows.ApplicationModel.Core
IUnhandledErrorMethods.Propagate (IObjectReference _obj)
Microsoft.AppCenter.Utils
ApplicationLifecycleHelperWinUI.<ctor>b__0_3 (Object sender, UnhandledErrorDetectedEventArgs eventArgs)

[0x5bfa]

It's really weird that this happens in this very method, which is almost the same as before in ThemeHelper.

Do you think it's fine to add try-catch to the method?
If failed, output the exception to the logger.

[yaira2]

That should work, and we can log additional info to help debug in the future.