Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Get rid of code duplication which handles RDBMS requests #1215

Open
1 of 4 tasks
alexander-pv opened this issue Aug 31, 2023 · 0 comments
Open
1 of 4 tasks

[FR] Get rid of code duplication which handles RDBMS requests #1215

alexander-pv opened this issue Aug 31, 2023 · 0 comments
Labels
feature New feature or request

Comments

@alexander-pv
Copy link

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feature Request Proposal

Now one anti-patter stands out quite strongly in the project - code duplication.
I suggest creating small python package to handle RDBMS requests and use it inside atleast sql-registry and access-control packages.

Motivation

What is the use case for this feature?

Reducing the number of anti-patterns in the project (python) will make it easier to maintain and develop by the community.

Details

In the process of studying the project, I made the first version of such package, with extended support for different databases (including PostgreSQL, MariaDB, MySQL): Link. I can open a PR with such change. Additionally, it is worth adding more tests.

What component(s) does this feature request affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant