Planting quick form does not always remember the last season

[mstenta]

Reported by a user via email, and replicated by myself in a test instance. I need to investigate more to determine the root cause, but I have a hunch that it has something to do with the way the entity_autocomplete widget's $form_state values different for new/existing entities in this code:

farmOS/modules/quick/planting/src/Plugin/QuickForm/Planting.php

Lines 492 to 499 in 3b21346

	// Remember the selected seasons for future reference.
	$season_ids = [];
	foreach ($plant_asset->get('season')->referencedEntities() as $entity) {
	$season_ids[] = $entity->id();
	}
	if (!empty($season_ids)) {
	$this->state->set('farm.quick.planting.seasons', $season_ids);
	}

[mstenta]

Hmm now that I'm digging into this, I have been unable to replicate it again. 🤔

I was in a bit of a rush when I tested originally, so it's possible that I didn't actually replicate it the first time. I will try a few more things, and I've asked the original reporter to see if they have more information, so I will report back...

[mstenta]

Closing this for now, but will reopen if we're able to replicate it consistently...

[mstenta]

Update: we figured out the cause. The user was trying to change "2023 (234)" in the form text field to "2024 (234)". But since "(234)" was still being included, it used that term ID ("2023") instead.

We really should remove those IDs... https://www.drupal.org/project/farm/issues/3263694