Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User 1 appears in Owner filter of farm_asset View #830

Closed
mstenta opened this issue Apr 23, 2024 · 1 comment · Fixed by #835
Closed

User 1 appears in Owner filter of farm_asset View #830

mstenta opened this issue Apr 23, 2024 · 1 comment · Fixed by #835
Labels
bug

Comments

@mstenta
Copy link
Member

mstenta commented Apr 23, 2024

When viewing lists of assets generated by the farm_asset View, the "Owner" filter currently includes user 1 in the list of options. User 1 is not included in the list of logs generated by the farm_log View. These should work consistently, and should not show user 1.

Reported here: https://farmos.discourse.group/t/odd-behavior-with-users-admin/1985
@mstenta mstenta added the bug label Apr 23, 2024
mstenta added a commit to mstenta/farmOS that referenced this issue Apr 29, 2024
@mstenta
Use farm_people entity_reference View for exposed Owner filter in far…
0d48128 
…m_asset View

Fixes User 1 appears in Owner filter of farm_asset View farmOS#830
@mstenta mstenta mentioned this issue Apr 29, 2024
Merged
mstenta added a commit to mstenta/farmOS that referenced this issue Apr 29, 2024
@mstenta
Use farm_people entity_reference View for exposed Owner filter in far…
7299281 
…m_asset View farmOS#835

Fixes User 1 appears in Owner filter of farm_asset View farmOS#830
@mstenta
Copy link
Member Author

mstenta commented Apr 29, 2024

I figured out why this was happening. The farm_log View uses the farm_people View to generate the list of users for the exposed filter, which omits user 1. The farm_asset View was using the default settings, not the farm_people View. I opened a PR to change that: #835

@mstenta mstenta linked a pull request Apr 29, 2024 that will close this issue
Use farm_people entity_reference View for exposed Owner filter in farm_asset View #835
Merged
mstenta added a commit to mstenta/farmOS that referenced this issue May 7, 2024
@mstenta
Use farm_people entity_reference View for exposed Owner filter in far…
fa57274 
…m_asset View farmOS#835

Fixes User 1 appears in Owner filter of farm_asset View farmOS#830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use farm_people entity_reference View for exposed Owner filter in farm_asset View mstenta/farmOS
1 participant
@mstenta