Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log name when no location selected in the asset move form #538

Open
paul121 opened this issue May 30, 2022 · 1 comment
Open

Improve log name when no location selected in the asset move form #538

paul121 opened this issue May 30, 2022 · 1 comment
Labels

Comments

@paul121
Copy link
Member

paul121 commented May 30, 2022

Describe the bug
Normally when the asset move action is used to move an asset to a new location the location names are included in the activity log: Move {assets} to {locations}. But if no locations are selected in the form we use the same logic to build the log name, which ends up with an incomplete Move {assets} to log name.

To Reproduce
Steps to reproduce the behavior:

  1. Go to assets page
  2. Click on an asset, select the "Move asset" action
  3. Complete the form without a location
  4. See new activity log with incomplete name

Expected behavior
We should name these logs better. Perhaps Reset {asset} location. ?

Screenshots
move_asset_no_location

@paul121 paul121 added the bug label May 30, 2022
@paul121
Copy link
Member Author

paul121 commented Jun 2, 2022

We just decided on the dev call for this language to be Clear {asset} location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant