Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data is not deleted when a data stream entity is deleted #488

Closed
mstenta opened this issue Jan 16, 2022 · 2 comments
Closed

Data is not deleted when a data stream entity is deleted #488

mstenta opened this issue Jan 16, 2022 · 2 comments
Labels
bug

Comments

@mstenta
Copy link
Member

mstenta commented Jan 16, 2022

Steps to reproduce:

  1. Create a sensor asset.
  2. Copy curl command from "Developer information" and run it to post a data point.
  3. Delete the data_stream entity that was created (need to disable entity reference integrity constraint first, see Data streams cannot be deleted or removed from sensor assets #485)
  4. Look in the database, the data is still there.
@mstenta mstenta added the bug label Jan 16, 2022
@mstenta
Copy link
Member Author

mstenta commented Jan 16, 2022

Looks like we just don't have any code to clean this up. A simple solution is to add a DELETE query to the existing data_stream_data_stream_delete() function.

mstenta added a commit to mstenta/farmOS that referenced this issue Jan 16, 2022
@mstenta
Delete data when basic data streams are deleted. Fixes farmOS#488
570c2db
@mstenta mstenta mentioned this issue Jan 16, 2022
Merged
@mstenta
Copy link
Member Author

mstenta commented Jan 17, 2022

Opened PR #489 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mstenta