Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply "done" flag to future events in quick forms #417

Closed
Zooka1 opened this issue Mar 16, 2021 · 2 comments
Closed

Do not apply "done" flag to future events in quick forms #417

Zooka1 opened this issue Mar 16, 2021 · 2 comments

Comments

@Zooka1
Copy link

Zooka1 commented Mar 16, 2021

Soil Amendment and Soil Disturbance quick forms automatically mark logs as complete, even for future events. Untested other quick forms.

Opposite of #333; check if date is in the future and do not apply "done" flag.

@Zooka1 Zooka1 added the bug label Mar 16, 2021
@mstenta
Copy link
Member

mstenta commented Mar 22, 2021

Agreed - it would be nice to take a similar approach as the Planting quick form, which has "Completed" checkboxes for each log.

FWIW we are going to be reviewing all quick forms for porting to farmOS 2.x soon - so that may be when we address this.

Patches/PRs welcome for 1.x, of course!

@mstenta
Copy link
Member

mstenta commented Aug 29, 2022

I'm going to close this as "won't fix" for farmOS v1. We haven't ported these two quick forms to farmOS v2 yet, and I'm not sure if we will or not (no one has asked for them specifically). If so then we can address this then. No new development is taking place on the 1.x branch at this time.

@mstenta mstenta closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants