Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework resolve method #52

Open
jgaehring opened this issue Nov 20, 2021 · 0 comments
Open

Rework resolve method #52

jgaehring opened this issue Nov 20, 2021 · 0 comments
Milestone

Comments

@jgaehring
Copy link
Member

As I mentioned in #22 (comment), I'm really not confident in the design of the resolve method, but I don't think it makes much sense to solidify it before farmOS/field-kit#190 is completed, so I can be sure how it will work in practice.

I suppose the most immediate concern for now is, if I anticipate major changes to this method, should I remove the documentation and/or the implementation I have now?

In the course of framing that question I think I've made up my mind... It needs to be removed; there's really no good reason to keep it.

So I've deleted the implementation, the docs and the tests for now and can revert the commit (195b3f0) when I'm ready to revisit this.

@jgaehring jgaehring added this to the 2.0.0 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant