Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 'elm-pep' pointer events polyfill for old browsers. #88 #89

Closed
wants to merge 3 commits into from
Closed

Include 'elm-pep' pointer events polyfill for old browsers. #88 #89

wants to merge 3 commits into from

Conversation

paul121
Copy link
Member

@paul121 paul121 commented Sep 19, 2020 •
edited

Only adds 2kiB, seems safe to include the polyfill in main.js so we know it is always included? I believe this would need to be included for controls, interactions & behaviors as they all might provide pointer events and be effected. So perhaps it would be better to include the polyfill in defaults.js?

I'm not too familiar with polyfills & unsure what is best! I'll add a commit for both of those options, can include either one.

Before:

Hash: 2c651843bac22a73b9e8
Version: webpack 4.44.0
Time: 5846ms
Built at: 09/19/2020 11:52:18 AM
        Asset      Size  Chunks                    Chunk Names
farmOS-map.js   541 KiB       0  [emitted]  [big]  main
   index.html  1.06 KiB          [emitted]         
    mapbox.js  13.4 KiB          [emitted]

After:

Hash: 3c160e4130076d992653
Version: webpack 4.44.0
Time: 1528ms
Built at: 09/19/2020 11:51:14 AM
        Asset      Size  Chunks                    Chunk Names
farmOS-map.js   543 KiB       0  [emitted]  [big]  main
   index.html  1.06 KiB          [emitted]         
    mapbox.js  13.4 KiB          [emitted]

@mstenta
Copy link
Member

mstenta commented Sep 21, 2020

Postponed pending license discussion in #88

@mstenta mstenta linked an issue Sep 21, 2020 that may be closed by this pull request
Cannot click & drag the map in desktop Safari #88
Open
@mstenta mstenta closed this Feb 8, 2021
@mstenta mstenta deleted the branch farmOS:master February 8, 2021 15:21
@mstenta
Copy link
Member

mstenta commented Feb 8, 2021

Oops - I changed the default branch to 1.x - forgot that this would affect open PRs. :-(

@mstenta
Copy link
Member

mstenta commented Feb 8, 2021

Sorry @paul121 ! You can open a new PR against 1.x if you'd like...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
postponed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot click & drag the map in desktop Safari
2 participants
@paul121 @mstenta