Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OL v7 #178

Open
paul121 opened this issue Aug 19, 2022 · 3 comments
Open

OL v7 #178

paul121 opened this issue Aug 19, 2022 · 3 comments

Comments

@paul121
Copy link
Member

paul121 commented Aug 19, 2022

Tracking for bumping the OL dependency to v7: https://github.com/openlayers/openlayers/releases/tag/v7.0.0

I noticed a couple breaking changes that may effect us:

The forEachLayerAtPixel method has been removed from the Map class.

I know we use this downstream in farmOS, likely in farmOS-map too?

Deprecated options have been removed from the Overlay component.

Might not directly effect us but should check on the ol-popup library which uses an overlay.

@paul121
Copy link
Member Author

paul121 commented Sep 28, 2022

I only see one usage of the map.forEachLayerAtPixel method in farmOS-map core:

var feature = myMap.map.forEachFeatureAtPixel(event.pixel, function(feature, layer) { return feature; });

We use it much more in farmOS core for the "popup" behavior.

@mstenta
Copy link
Member

mstenta commented Sep 28, 2022

@paul121 We don't use forEachLayerAtPixel() in either farmOS core or farmOS-map core, we use forEachFeatureAtPixel(), which hasn't been deprecated.

forEachFeatureAtPixel() is still part of OL 7.1.0: https://openlayers.org/en/latest/apidoc/module-ol_Map-Map.html#forEachFeatureAtPixel

@paul121
Copy link
Member Author

paul121 commented Sep 28, 2022

Oh my, good catch thanks @mstenta !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants