Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Hub image automated builds broken #124

Open
mstenta opened this issue Jan 18, 2023 · 2 comments
Open

Docker Hub image automated builds broken #124

mstenta opened this issue Jan 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mstenta
Copy link
Member

mstenta commented Jan 18, 2023

I broke the automated builds on Docker Hub when I cleaned up after farmOS/farmOS#580 :-(

Opening this so we don't forget about it...

@mstenta mstenta added the bug Something isn't working label Jan 18, 2023
@mstenta
Copy link
Member Author

mstenta commented Jan 18, 2023

We have a choice here:

  1. Try to set it up like it was before (or similar). I think this will require creating a new GitHub "machine user". Previously we had a farmOS-docker user which I deleted.
  • Remove farmOS-docker GitHub user from "Linked Accounts" in farmOS organization settings.
    • Deactivate farmOS-docker GitHub user? I don't think this is used for anything else.

farmOS/farmOS#580 (comment)

  1. Build the images via GitHub Actions and push to Docker Hub, like we are now doing for farmOS.

@mstenta
Copy link
Member Author

mstenta commented Jan 18, 2023

Build the images via GitHub Actions and push to Docker Hub, like we are now doing for farmOS.

I'd rather go this route, if possible, for consistency and simplicity/security (no need to maintain another GitHub user, all controlled through the same shared GitHub secrets that the farmOS repo uses). It requires some development/testing though...

It also means we'd have to manually create/push the 2.0.0-beta2 tag I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant