Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when taking premade character after cycling between characters #530

Open
phobos2077 opened this issue Apr 24, 2017 · 3 comments
Open
Labels

Comments

@phobos2077
Copy link
Contributor

Description

A Segfault in unique_ptr move assignment when taking premade character after cycling between characters.
Game.cpp:194

System

OS: Ubuntu 17.04 x64
Compiler: GCC

Steps to reproduce

  1. Go to main menu.
  2. Click new game.
  3. Click left or right buttons to switch premade characters.
  4. Press Take.
@phobos2077 phobos2077 added the bug label Apr 24, 2017
@Zervox
Copy link
Contributor

Zervox commented Apr 25, 2017

I was unable to reproduce this segfault,
but similar segfault(not suprised if they are the same issue)

  1. new game,
  2. select character
  3. take
  4. exit to menu
  5. repeat step 1-3

@phobos2077
Copy link
Contributor Author

Probably the same. I think someone who made this messed up move semantics usage.

@Zervox
Copy link
Contributor

Zervox commented Apr 26, 2017

doing a _player.release(); inside setPlayer fixes the issue.(should probably instead be handled on exit to menu and load functions to deal with, just in case someone wanted to write a script to change the player

for the original error, I am not sure this one works, but as I have been unable to reproduce the problem through those steps I am unable to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants