Duplicate code for parsing INI files

[Zervox]

I noticed that there is already a Parser set in Txt, toInt, toDouble and toBool, could be moved from Ini::Value into Parser as static with const std::string, replacing all Value with std::string instead.(no point having a duplicate structure for something which could be called as generics.

[phobos2077]

What is the real benefit of this change? Is there any real issue? Also note that Ini::Value holds a union of various types, not just std::string so you can't trivially replace it.

[Zervox]

benefits:
less inclusions for getting the same functionality which Txt files still uses from Ini::
Ini::Value holds no union of types, it holds a string and performs the same operations Txt::Parser does, it converts a std::string to value or to array, making toInt, toDouble and toBool static.
merging these two structures' functionality actually is trivial
cons:
Haven't found any, runs exactly the same, no performance differnce and no data difference, no loss of functionality.

[phobos2077]

There are actually 2 Ini::Value classes in falltregeist::Ini and falltergeist::Format::Ini namespaces, basically duplicated functionality. The first was written long time ago to just read the settings for falltergeist itself, the second was created specifically for parsing game text formats. I don't see any duplicated functionality within each of these two. Are you sure you're not mixing them up?

So the actual issue is to maybe get rid of Falltergeist::Ini classes altogether and use the one from Formats instead...

[667bdrm]

city.txt parser has useful logic for getting array of properties by simple regilar expression. (example: entrance_%d) Moving this to common parser could be useful in future.