Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on MacOS 13 and targeting MacOS 11 and SDK 11.3 (or any other MacOS version) does not work #4038

Open
lukaso opened this issue May 8, 2024 · 2 comments

Comments

@lukaso
Copy link

lukaso commented May 8, 2024

Describe the bug
As of v1.5.6, the minos and sdk settings are no longer respected. This works on version 1.5.5.

(It is possible this is an interaction with MacPorts where I am building the library.

To Reproduce
Steps to reproduce the behavior:

  1. Install macports
  2. echo 'macosx_deployment_target 11.0' | tee -a ${PREFIX}/etc/macports/macports.conf
    echo 'macosx_sdk_version 11.3' | tee -a ${PREFIX}/etc/macports/macports.conf
  3. sudo port install -sv zstd
  4. look in macports lib directory and run otool -l libzstd.1.dylib
  5. see output includes minos and sdk of the current OS, rather than minos 11.0 and sdk 11.3

Expected behavior
Should correctly set the OS and SDK versions in the dylib.

Screenshots and charts
If applicable, add screenshots and charts to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac
  • Version 14.4.1
  • Compiler clang
  • Flags not sure
  • Other relevant hardware specs not relevant
  • Build system CMAKE

Additional context
Downstream bug reports:
https://trac.macports.org/ticket/69944#comment:1
https://gitlab.gnome.org/GNOME/gimp/-/issues/11483

@Cyan4973
Copy link
Contributor

Cyan4973 commented May 8, 2024

Isn't that a MacPorts issue ?

@lukaso
Copy link
Author

lukaso commented May 9, 2024

Isn't that a MacPorts issue ?

I doubt it because other than trivial changes to the MacPorts build file (Portfile), the build is unchanged between 1.5.5 and 1.5.6. And 1.5.5 doesn't have this problem. It could potentially be MacPorts if they are using a non-standard way of indicating the OS and SDK, however the hundreds of other packages on MacPorts that GIMP uses, don't have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants