{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":455600,"defaultBranch":"master","name":"hhvm","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-01-02T01:17:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708115215.0","currentOid":""},"activityList":{"items":[{"before":"712c5e836b0b16ee7ad0f0b4119bfe1c1d9e887e","after":"eac69c2a8b3df2d23258280d63b06725dbf4867e","ref":"refs/heads/master","pushedAt":"2024-06-01T16:37:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/6ed9232c372ee58f23f31a465ee64047ade74169\nhttps://github.com/facebook/fb303/commit/9b5a5f3b91d3445419628f6958f8e5f9e84b6b46\nhttps://github.com/facebook/fbthrift/commit/51bc3104dd54ae0bb80210e417d1eacc5e7a5989\nhttps://github.com/facebook/folly/commit/93bb6d06fec49ae7a56be5f8eec66c356028fe7d\nhttps://github.com/facebook/mvfst/commit/554c94acdd404f6bf6f1c8ce05448db5ba5f9a96\nhttps://github.com/facebook/proxygen/commit/343db73eabe6a4352c9734bfcaa91d9498f15222\nhttps://github.com/facebook/wangle/commit/ce1e98cb46bcbcac47fb4b226d93bf8e53094e2f\nhttps://github.com/facebookexperimental/edencommon/commit/bdd6748988b0c2ee4fa32398983514865dad757d\nhttps://github.com/facebookexperimental/rust-shed/commit/31a8db9294e99bc424e5fde4dc4426ced37bd062\nhttps://github.com/facebookincubator/fizz/commit/6e67555602f093698b3ee3261a3b02510cd28402\n\nReviewed By: namanahuja\n\nfbshipit-source-id: 338c6322939c9185ca4d330d500ce09c42d2f73f","shortMessageHtmlLink":"Updating submodules"}},{"before":"ecdc7487415dcfd4690ee1094b7b3a59b53aeb8e","after":"712c5e836b0b16ee7ad0f0b4119bfe1c1d9e887e","ref":"refs/heads/master","pushedAt":"2024-06-01T15:20:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add ghc (#850)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/zstrong/pull/850\n\nReviewed By: markbt\n\nDifferential Revision: D58011866\n\nfbshipit-source-id: 3c6a8443f7fd9c512837d27162a2399c21eb243c","shortMessageHtmlLink":"Add ghc (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"16789578\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hhvm/issues/850\" data-hovercard-type=\"issue\" data-hovercard-url=\"/facebook/hhvm/issues/850/hovercard\" href=\"https://github.com/facebook/hhvm/issues/850\">#850</a>)"}},{"before":"bc7ca1dd83129542ac249d574982bac852ec3e33","after":"ecdc7487415dcfd4690ee1094b7b3a59b53aeb8e","ref":"refs/heads/master","pushedAt":"2024-06-01T14:33:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"--shared-libs should be a common argument\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/848\n\nBecause it should work with `show-inst-dir`, otherwise we can't\ncalculate the right project hash.\n\nReviewed By: chadaustin\n\nDifferential Revision: D58011867\n\nfbshipit-source-id: d8960b4a993efbada8e27584e56976279fcd6b43","shortMessageHtmlLink":"--shared-libs should be a common argument"}},{"before":"652e51397da5926644517acd22868b9db3eb76d4","after":"bc7ca1dd83129542ac249d574982bac852ec3e33","ref":"refs/heads/master","pushedAt":"2024-06-01T11:17:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use the correct default syscall number for _NR_membarrier\n\nSummary: This value is arch-specific. Add aarch64 support.\n\nReviewed By: davidtgoldblatt\n\nDifferential Revision: D58020584\n\nfbshipit-source-id: 211005711dfaeff0d2b711a88ed815fd2a85ab52","shortMessageHtmlLink":"Use the correct default syscall number for _NR_membarrier"}},{"before":"601fb0e44ee7caa6dfe7f8994ee0ccd3b3674ba4","after":"652e51397da5926644517acd22868b9db3eb76d4","ref":"refs/heads/master","pushedAt":"2024-06-01T09:20:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix pkg-config generation: libdir was wrong\n\nSummary:\nThe symptom is that folly installs under `${libdir}/lib` while the\ngenerated `libfolly.pc` specifies `libdir=${exec_prefix}/lib64`, so\nanyone using pkg-config to depend on folly gets the wrong libdir.\n\nI only vaguely understand this stuff, but it seems like\n`libfolly.pc.in` is using `CMAKE_INSTALL_LIBDIR` while the cmake\nconfig itself is using `LIB_INSTALL_DIR`, so I just fixed\n`libfolly.pc.in` to match.\n\nReviewed By: josefs\n\nDifferential Revision: D57964534\n\nfbshipit-source-id: 409de298ffa6ff012407e1d055c11f7caa06b626","shortMessageHtmlLink":"Fix pkg-config generation: libdir was wrong"}},{"before":"d1ce7f09694ebf12e9c5ece024b5a0e4df693e22","after":"601fb0e44ee7caa6dfe7f8994ee0ccd3b3674ba4","ref":"refs/heads/master","pushedAt":"2024-06-01T02:16:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-use MNIST skycastle job to enable run_kernel.py CI test\n\nSummary:\n- Updated the MNIST job from diff 1/2 to be more generic\n- Same .sky file now supports training, kernel, and bench testing\n- Renamed RLS test suites and updated commands to be compatible with new skycastle flow\n- Removed mtia_qemu_amodel_kernel_and_bench_bmtc.sky file since this was merged with MNIST sky job\n\nDifferential Revision: D57943026\n\nfbshipit-source-id: 7f5977cf8e12f6473647c11464bef1852aa936f9","shortMessageHtmlLink":"Re-use MNIST skycastle job to enable run_kernel.py CI test"}},{"before":"c499ef789c20954436823f74d7cba4532ba3054d","after":"d1ce7f09694ebf12e9c5ece024b5a0e4df693e22","ref":"refs/heads/master","pushedAt":"2024-06-01T00:19:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix oss linker issue\n\nSummary: New file added but was not compiled\n\nReviewed By: ahilger\n\nDifferential Revision: D58030626\n\nfbshipit-source-id: 3f16893fa668a3b97edbcc84e0dcedc25b7bee28","shortMessageHtmlLink":"Fix oss linker issue"}},{"before":"6c9af0d785b3a331d8231f799c1589046771d397","after":"c499ef789c20954436823f74d7cba4532ba3054d","ref":"refs/heads/master","pushedAt":"2024-05-31T23:56:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Initial implementation for `MutableMap`\n\nSummary:\nThis is an initial implementation for the `Thrift MutableMap`. It implements `MutableMapping` from the [collections abstract base classes](https://docs.python.org/3.10/library/collections.abc.html?fbclid=IwAR05ocojd-kFjIU6xh9MNXcQrbwTShPXopvpQNpfT_WIADoqCW8Mgf0PiFQ#collections-abstract-base-classes). However, not all abstract methods are implemented; these can be completed later.\nWhile the implementation could be optimized, especially for integral types, it is not within the scope of this diff.\n\nReviewed By: aristidisp\n\nDifferential Revision: D57738398\n\nfbshipit-source-id: 714c9ccced0641cbdbff8c0a47f13baac10250aa","shortMessageHtmlLink":"Initial implementation for <code>MutableMap</code>"}},{"before":"a43c49528bd4bc801d8604652113379a141a22e6","after":"6c9af0d785b3a331d8231f799c1589046771d397","ref":"refs/heads/master","pushedAt":"2024-05-31T23:41:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"constexpr type_info_of\n\nSummary:\nLet `type_info_of` be `constexpr`. Let `StaticSingletonManager::Arc` be `constexpr`-constructible, and enforce it.\n\nHistorically, these could not be `constexpr` and `constexpr`-constructible because older versions of MSVC rejected `constexpr` with `typeid`.\n\nReviewed By: Gownta\n\nDifferential Revision: D55642689\n\nfbshipit-source-id: 98cb577fdb9d921865720d9c91b6219bd6a153b9","shortMessageHtmlLink":"constexpr type_info_of"}},{"before":"22ca379914915c30fca563baa3117bd9f818b55f","after":"a43c49528bd4bc801d8604652113379a141a22e6","ref":"refs/heads/master","pushedAt":"2024-05-31T22:54:35.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Clean up ObjectTest::testParseObjectWithMask\n\nSummary:\n* fix error in comment\n* change exclude mask to include mask to accurately capture the comment intent (masking object[3][6] instead of excluding [3][5])\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58025148\n\nfbshipit-source-id: ee3f7dcd8b48e20f9fd21f5f352a828ae259b1ae","shortMessageHtmlLink":"Clean up ObjectTest::testParseObjectWithMask"}},{"before":"112ae9d21e3f291ccce85c4474ac24e7319e86c3","after":"22ca379914915c30fca563baa3117bd9f818b55f","ref":"refs/heads/master","pushedAt":"2024-05-31T22:48:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Store reference to the HTTP request in RequestStartedEvent\n\nSummary: Store a reference to the corresponding HTTP request in RequestStartEvent instead of just HTTPHeaders.\n\nDifferential Revision: D57868690\n\nfbshipit-source-id: 2d9a1df83e24a1fc59b5a126a875159df5193a65","shortMessageHtmlLink":"Store reference to the HTTP request in RequestStartedEvent"}},{"before":"ec369a71db5cacfc093b4f2994d44ae27c83a3e5","after":"112ae9d21e3f291ccce85c4474ac24e7319e86c3","ref":"refs/heads/master","pushedAt":"2024-05-31T22:32:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove reference to deleted sub-template\n\nSummary:\nThis sub-template was deleted so always evaluates to `\"\"`.\n\nAlso update some comments (mention of `Structs.pyx` lol).\n\nReviewed By: yoney\n\nDifferential Revision: D57998087\n\nfbshipit-source-id: a93df5134c9a548ffae82e0597d8db7b55e7559f","shortMessageHtmlLink":"remove reference to deleted sub-template"}},{"before":"32db162d5a85a717bb28a1546d3774a1fea92970","after":"ec369a71db5cacfc093b4f2994d44ae27c83a3e5","ref":"refs/heads/master","pushedAt":"2024-05-31T22:11:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Hash values in hash mode\n\nSummary: As with definitions in the previous diff, we compute a hash identifier for values to allow identifying them consistently when sharding and merging schemas. As an added bonus this deduplicates the values.\n\nReviewed By: praihan\n\nDifferential Revision: D57974622\n\nfbshipit-source-id: ce578451736deafd816f22b7a9eba17e67445b89","shortMessageHtmlLink":"Hash values in hash mode"}},{"before":"0c68190f6494991b5b84c1dcbc89209cb9ed1b90","after":"32db162d5a85a717bb28a1546d3774a1fea92970","ref":"refs/heads/master","pushedAt":"2024-05-31T21:58:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"SinkServiceTest: skip (i.e., disable) flaky test\n\nReviewed By: thedavekwon, AkramaMirza\n\nDifferential Revision: D58021812\n\nfbshipit-source-id: b2de1c9cfa8254a170597cee190283329733554c","shortMessageHtmlLink":"SinkServiceTest: skip (i.e., disable) flaky test"}},{"before":"6aa7bbc6e32783f31a96994557a5d5a328a3661c","after":"0c68190f6494991b5b84c1dcbc89209cb9ed1b90","ref":"refs/heads/master","pushedAt":"2024-05-31T21:48:56.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Separate AddCert and AddCertAndOverride for client side cert managers\n\nSummary: Mirroring the change from the server side diff D57737100, to refactor `addcert` function from client cert managers, so no functions with bool default param are exposed as public function.\n\nDifferential Revision: D57939731\n\nfbshipit-source-id: 532753592b13a4ea116c6bb015591d48878ace4c","shortMessageHtmlLink":"Separate AddCert and AddCertAndOverride for client side cert managers"}},{"before":"2f778c4a13409c01f758fa1d23b8303518795680","after":"6aa7bbc6e32783f31a96994557a5d5a328a3661c","ref":"refs/heads/master","pushedAt":"2024-05-31T21:34:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"types.cpp/h: minor refactoring\n\nReviewed By: yoney\n\nDifferential Revision: D57954996\n\nfbshipit-source-id: a7211a9810e05ee3a10bdbd922c443a70a1b2bd2","shortMessageHtmlLink":"types.cpp/h: minor refactoring"}},{"before":"633862847f01738010910d3919846c4a128247d0","after":"2f778c4a13409c01f758fa1d23b8303518795680","ref":"refs/heads/master","pushedAt":"2024-05-31T21:08:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow benchmarks with hh + hh_distc\n\nSummary: To allow benchmarks with hh + hh_distc (i.e. hh_server calling into hh_distc FFI), we need to force disabling RE cache and force local tracing, which we do with hh_distc by passing options `--no-cache --trace-store-mode local`. With this diff, passing config flags `re_no_cache=true` and `hh_distc_should_disable_trace_store=true` will do what we want.\n\nDifferential Revision: D58011147\n\nfbshipit-source-id: 133584a767a9dce20427762cb51349eb044cd28e","shortMessageHtmlLink":"Allow benchmarks with hh + hh_distc"}},{"before":"d3f0ab81900736c188e0a1be0ec1a26c9810448d","after":"633862847f01738010910d3919846c4a128247d0","ref":"refs/heads/master","pushedAt":"2024-05-31T21:00:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix order of writeFieldStop and writeStructEnd for TableBasedSerializer::writeUnion\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58021531\n\nfbshipit-source-id: 7d4a96daf7499b91376d6e54be8e9730ae54c85e","shortMessageHtmlLink":"Fix order of writeFieldStop and writeStructEnd for TableBasedSerializ…"}},{"before":"4f759b5f7daa46329bef48de7a6ba5083d6e4f89","after":"d3f0ab81900736c188e0a1be0ec1a26c9810448d","ref":"refs/heads/master","pushedAt":"2024-05-31T20:09:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Cleanup TestStreamService.cpp and TestSinkService.cpp\n\nSummary: Cleanup some redundant namespace specifiers in test files\n\nReviewed By: avalonalex\n\nDifferential Revision: D58020113\n\nfbshipit-source-id: d689b8425f368a018d0cef5c0490598aa0eb9085","shortMessageHtmlLink":"Cleanup TestStreamService.cpp and TestSinkService.cpp"}},{"before":"53ab1328e03d2bc27b62fc37d866b5e368079143","after":"4f759b5f7daa46329bef48de7a6ba5083d6e4f89","ref":"refs/heads/master","pushedAt":"2024-05-31T19:34:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix namespace for TestStreamService\n\nReviewed By: avalonalex\n\nDifferential Revision: D58019196\n\nfbshipit-source-id: 0fd771e660746565444ffd06aa702663af9313fa","shortMessageHtmlLink":"Fix namespace for TestStreamService"}},{"before":"53a39d060cbca0c3be01598647eeed4f58bfd9d9","after":"53ab1328e03d2bc27b62fc37d866b5e368079143","ref":"refs/heads/master","pushedAt":"2024-05-31T19:29:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move ReadMostlySharedPtr to fbcode/folly/concurrency/memory\n\nSummary:\nThe following targets were moved to folly/concurrency/memory:\n```\n//folly/experimental:read_mostly_shared_ptr\n//folly/experimental/test:read_mostly_shared_ptr_benchmark\n//folly/experimental/test:read_mostly_shared_ptr_stress_test\n//folly/experimental/test:read_mostly_shared_ptr_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: Orvid\n\nDifferential Revision: D57730011\n\nfbshipit-source-id: 21a746a2f6dacdc205c985445a7250de459346e9","shortMessageHtmlLink":"Move ReadMostlySharedPtr to fbcode/folly/concurrency/memory"}},{"before":"c1842ca369a9330fe01a3cb64857c11add64c827","after":"53a39d060cbca0c3be01598647eeed4f58bfd9d9","ref":"refs/heads/master","pushedAt":"2024-05-31T18:58:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Introduce test utils for thrift compiler tests\n\nSummary: Intorduce `test_utils.h` to add helper functions like `PrintTo()` for gtest.\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58022743\n\nfbshipit-source-id: 6bebe7ac2a0d145e2f4bb7a26250b28df49f5358","shortMessageHtmlLink":"Introduce test utils for thrift compiler tests"}},{"before":"7937e13be62884a5ca5b95e8fcc2bfb0b1d4b582","after":"c1842ca369a9330fe01a3cb64857c11add64c827","ref":"refs/heads/master","pushedAt":"2024-05-31T18:48:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow SYS_membarrier on aarch64\n\nSummary:\nThere's no reason that `SYS_membarrier` usage should be limited to x86_64, so open it up for aarch64.\n\nFor non-x86_64 platforms, fall back to `std::atomic_thread_fence` (rather than relying on mprotect side-effects) when `SYS_membarrier` is unavailable.\n\nReviewed By: ot\n\nDifferential Revision: D58010235\n\nfbshipit-source-id: fb42c11b00d1a7032ba27eda225c0a824c3f91ad","shortMessageHtmlLink":"Allow SYS_membarrier on aarch64"}},{"before":"95a248349f7ed9f14670c9453cea141979f42a40","after":"7937e13be62884a5ca5b95e8fcc2bfb0b1d4b582","ref":"refs/heads/master","pushedAt":"2024-05-31T18:42:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move FunctionScheduler to fbcode/folly/executors\n\nSummary:\nThe following targets were moved to folly/executors:\n```\n//folly/experimental:function_scheduler\n//folly/experimental/test:function_scheduler_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:ad_mefs.folly\n\nReviewed By: Orvid\n\nDifferential Revision: D57934086\n\nfbshipit-source-id: 6b845eb6ac17e7a800d79a866028d6f483aacf49","shortMessageHtmlLink":"Move FunctionScheduler to fbcode/folly/executors"}},{"before":"0f31c69743d217f4b8e90a1d22d67c0adb72049a","after":"95a248349f7ed9f14670c9453cea141979f42a40","ref":"refs/heads/master","pushedAt":"2024-05-31T18:16:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move AutoTimer to fbcode/folly/logging\n\nSummary:\nThe following targets were moved to folly/logging:\n```\n//folly/experimental:auto_timer\n//folly/experimental/test:auto_timer_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:ad_meat\n\nReviewed By: vitaut\n\nDifferential Revision: D57929227\n\nfbshipit-source-id: 9bb070c1fc3e0ccc8d2597c1026e77a7041602b6","shortMessageHtmlLink":"Move AutoTimer to fbcode/folly/logging"}},{"before":"68c21631197334724d7e10bf61aec0a46c89afbd","after":"0f31c69743d217f4b8e90a1d22d67c0adb72049a","ref":"refs/heads/master","pushedAt":"2024-05-31T17:47:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move LockFreeRingBuffer to fbcode/folly/concurrency/container\n\nSummary:\nThe following targets were moved to folly/concurrency/container:\n```\n//folly/experimental:lock_free_ring_buffer\n//folly/experimental/test:lock_free_ring_buffer_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:ad_melfrb.folly\n\nReviewed By: Orvid\n\nDifferential Revision: D57935114\n\nfbshipit-source-id: 43c22359f76ed73087020a4eae73107471c93126","shortMessageHtmlLink":"Move LockFreeRingBuffer to fbcode/folly/concurrency/container"}},{"before":"c4ab05cd6b3139e7091e39f6a573344c1a6d5d46","after":"68c21631197334724d7e10bf61aec0a46c89afbd","ref":"refs/heads/master","pushedAt":"2024-05-31T17:39:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Adjusting the WritableIOBuf to be able to take an int for initialization\n\nSummary:\nWe want to be able to use C++ to initialize the buffer, to increase the speed of allocation. This seems to be primarily from how Python appears to allocate and zero out the bits in the buffer.\n\nThis diff passes along the capacity to the C++ code to initialize the buffer.\n\nAdditionally, I changed some of the ways for how we initialize the WritableIOBuf as length & capacity are not the same thing. From the documentation, this is a diagram for the difference.\n```\n *      +-------+\n *      | IOBuf |\n *      +-------+\n *       /\n *      |            |----- length() -----|\n *      v\n *      +------------+--------------------+-----------+\n *      | headroom   |        data        |  tailroom |\n *      +------------+--------------------+-----------+\n *      ^            ^                    ^           ^\n *      buffer()   data()               tail()      bufferEnd()\n *\n *      |----------------- capacity() ----------------|\n```\n\nIf you treat them as the same, when grabbing the bytes for an empty buffer, you get some gibberish for unitialized bytes `\\xbe`. However, as my diff makes the change to use them according to the IOBuf spec, that no longer happens.\n\nHowever, due to that change, we now need to account for management of the buffer pointers. So, this added a few of the ways that we can adjust the pointers (`append`, `prepend`, `trimStart`, `trimEnd`).\n\nUltimately, this seemed to be the correct tradeoff, in order to keep getting what are expected results. The next diff then shows this in action, and how we can use this to optimize Manifold's read operation.\n\nReviewed By: mofa28\n\nDifferential Revision: D57890817\n\nfbshipit-source-id: 009b6e53700c3456a9dd6b69d554320cb5ff409a","shortMessageHtmlLink":"Adjusting the WritableIOBuf to be able to take an int for initialization"}},{"before":"f1e75ed0287de380baf4eb9dbf2327ee306b416e","after":"c4ab05cd6b3139e7091e39f6a573344c1a6d5d46","ref":"refs/heads/master","pushedAt":"2024-05-31T16:37:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/f14410f0bc45fd1c53eb56698fb5bcfac42758f7\nhttps://github.com/facebook/fb303/commit/17976a6492a1b923a5cebb9b1d0003c24703ffd4\nhttps://github.com/facebook/fbthrift/commit/b0901104ac78a24cbc2e017498035329327b76be\nhttps://github.com/facebook/folly/commit/4a96830b790513091f78aee6cc943a669713e855\nhttps://github.com/facebook/mvfst/commit/433d82d61413e323a553ab4586727017577a4d23\nhttps://github.com/facebook/proxygen/commit/9c5b517d6dcf8884c17e73e45458f2823734471e\nhttps://github.com/facebook/wangle/commit/8d32d1bf554777d9fde3eb2fb1019c2b51209a14\nhttps://github.com/facebookexperimental/edencommon/commit/8e50a2ee6169c4d9ec39a0bb7c3c6f61b033994f\nhttps://github.com/facebookexperimental/rust-shed/commit/e1cd2048f28c7a04bbd7f597b07b8e16206ffbf8\nhttps://github.com/facebookincubator/fizz/commit/824cbbe249ebb944edb97e348caea91a4d2ee750\n\nReviewed By: namanahuja\n\nfbshipit-source-id: 6a32b88b628eab7a8d8e75ec93ad270658c9f3eb","shortMessageHtmlLink":"Updating submodules"}},{"before":"f9218a159e1822f935c86bfeb7bfd680d9050992","after":"f1e75ed0287de380baf4eb9dbf2327ee306b416e","ref":"refs/heads/master","pushedAt":"2024-05-31T15:34:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unused configurableRequestProcessor\n\nSummary: remove unused configurableRequestProcessor\n\nReviewed By: echistyakov\n\nDifferential Revision: D57971844\n\nfbshipit-source-id: b02ebf3133d0dd6fe7c89ce53656f43d5de48bb0","shortMessageHtmlLink":"remove unused configurableRequestProcessor"}},{"before":"685cec06d80f02713d73d1f90be070d8dd8361a4","after":"f9218a159e1822f935c86bfeb7bfd680d9050992","ref":"refs/heads/master","pushedAt":"2024-05-31T15:22:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"enable metadata compatibility in auto-migrate\n\nSummary:\nAdd some basic metadata support for structs. It just takes one `issubclass` to divert things to the `python.metadata.gen_metadata` function.\n\nEverything seems to work except:\n- typedefs aren't resolved. This appears to be a bug in thrift-python metadata (T190871305) rather than an auto-migrate bug. Refactored these assertions into `brokenInAutoMigrate()` cases.\n\nReviewed By: yoney\n\nDifferential Revision: D57986056\n\nfbshipit-source-id: 5d7695baca3e77776b7240df34f431c2869867a4","shortMessageHtmlLink":"enable metadata compatibility in auto-migrate"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWc6oNAA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/hhvm"}