Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: to many out of gas txs calls to Staking Precompiles post-upgrade #2271

Open
VictorTrustyDev opened this issue Jan 16, 2024 · 13 comments
Assignees
Labels
bug Something isn't working precompile

Comments

@VictorTrustyDev
Copy link
Contributor

VictorTrustyDev commented Jan 16, 2024

Context

Post-upgrade v16, there are many out of gas txs which calls to Staking Precompiles, looks abnormal:
https://escan.live/address/0x0000000000000000000000000000000000000800

@luchenqun
Copy link
Contributor

I also noticed that, haha. The core reason is that the gas returned by the RPC interface eth_estimateGas is not accurate.

@VictorTrustyDev
Copy link
Contributor Author

Probably should apply a magic number like DefaultGasMultiplier of Cosmos-SDK which is 1.2

@luchenqun
Copy link
Contributor

I agree with your point.

@ramacarlucho ramacarlucho self-assigned this Jan 19, 2024
@ramacarlucho
Copy link
Contributor

Thanks for the report! Will investigate

Copy link

linear bot commented Jan 23, 2024

ENG-2470 Issue 2271

@ramacarlucho
Copy link
Contributor

This was fixed by this PR.
If not, please reopen the issue.

@VictorTrustyDev
Copy link
Contributor Author

Although the txs look better atm and seems resolved somehow.
But I believe there is no relates to the PR you provided, because that PR fixes trace* methods.

@MalteHerrmann MalteHerrmann reopened this Feb 15, 2024
@MalteHerrmann
Copy link
Contributor

Reopening because the reason for this is not understood fully yet 👀.

@ramacarlucho
Copy link
Contributor

We believe that the execution of the txs were not failing, it was just the trace transaction that was giving the incorrect information.

Can you send us a failing tx so we can check?

@VictorTrustyDev
Copy link
Contributor Author

@ramacarlucho if Escan says the txs as failed, they actually failed during consensus.
I'm not bad enough to set the txs to be failed based on trace transaction result 🤣

Next time I will do screen capture.

@GAtom22
Copy link
Contributor

GAtom22 commented Feb 22, 2024

@VictorTrustyDev @luchenqun Do you see this happening on the Staking precompile only or in other precompiles too?

@GAtom22 GAtom22 added bug Something isn't working precompile labels Feb 22, 2024
@VictorTrustyDev
Copy link
Contributor Author

Unfortunately I didn't check the other precompiles that time.

Copy link

github-actions bot commented Apr 8, 2024

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working precompile
Projects
None yet
Development

No branches or pull requests

5 participants