Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative numbers fail validation #473

Open
sralchemab opened this issue Oct 13, 2022 · 3 comments
Open

Negative numbers fail validation #473

sralchemab opened this issue Oct 13, 2022 · 3 comments

Comments

@sralchemab
Copy link

Hi there,

I have a schema with a "Number" field. When I use a negative number for this parameter, I get the following error message:

--search_threshold: expected type: Number, found: String (-0.9)

A positive number works fine.

Is this a bug or am I missing something?

Thanks in advance for looking into this.

@erosb
Copy link
Contributor

erosb commented Oct 13, 2022

Hello, which library version is it?

@sralchemab
Copy link
Author

Hi @erosb, from the following link, it looks like the version we're using is 1.14.1.

https://github.com/nextflow-io/nf-validation/blob/37ea1b571977d8b8e26a7ff3636a115a3fda3498/plugins/nf-validation/build.gradle#L63

@erosb
Copy link
Contributor

erosb commented Apr 17, 2023

Hello @sralchemab , I released a new validator. With the new library -0.9 properly validates against {"type":"number"} schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants