Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive Joda Time version clash through json-schema's dependencies #403

Open
chriskilding opened this issue Feb 8, 2021 · 2 comments

Comments

@chriskilding
Copy link

Hi, I have a downstream project which is suffering a transitive Joda Time version clash from three of its dependencies, which in turn depend on Joda. json-schema is one of them.

The quick way to deal with this would be for me to add a Joda dependency to my own POM. But Joda was functionally deprecated nearly a decade ago by JDK8's release, so it would be preferable to remove Joda from upstream dependencies rather than spread it into new projects.

In json-schema's case, the dependency which drags Joda in is com.damnhandy:handy-uri-templates. This is used in just one class, URITemplateFormatValidator.

I've asked the author of handy-uri-templates to remove Joda, but he hasn't responded so far. The next best thing would be for json-schema to use a different URI template library. Would you be able to do this? I'm willing to work on the PR for it if necessary.

@chriskilding
Copy link
Author

The relevant upstream PR: damnhandy/Handy-URI-Templates#67

@erosb
Copy link
Contributor

erosb commented Feb 8, 2021

Hello @chriskilding , thank you for creating this issue. I won't have time to work on this, but I'm happy to review your PR if you decide to raise one. Please include extensive unittest coverage. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants