Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use linked hash maps where it matters #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshMcCullough
Copy link

Fixes #395.

Copy link
Contributor

@erosb erosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, using LinkedHashMap should be an optional feature which is disabled by default, due to possible performance degradation in some usecases (LinkedHashMap is slower than HashMap). So please make ordering toggle-able in SchemaLoaderBuilder, and instantiate HashMap / LinkedHashMap depending on the feature toggle during the schema loading process. For that you can start looking at ObjectSchemaLoader:59.
I think it is enough for now to implement order-keeping for "properties".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LinkedHashMap to preserve order of schema elements
2 participants