You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note sure the proper fix yet - just logging here for now.
To Reproduce
Use any client and test with the following:
Send a "monitor" message to the server. Any of them will hit the error with the missing ".get" on kwargs("outputfunc_name", "monitor")
For the monitored issue, just send a "monitored" command after monitoring some value from the client. THIS REQUIRES A FIX TO THE ABOVE FIRST! You will see an error in logs/server.log indicated earlier in this bug.
NOTE: I am using a custom client , but I'm not doing anything custom about these INPUT_FUNCS.
The text was updated successfully, but these errors were encountered:
scyfris
added
bug
An actual error or unwanted behavior.
needs-triage
Yet to be looked at and verified as an a real issue/feature that could be worked on
labels
Oct 29, 2023
scyfris
changed the title
[BUG] INPUT_FUNCs 'monitor' and 'monitored' cause errors.
[BUG] INPUT_FUNCs 'monitor' and 'monitored' are broken (python errors when trying to use)
Oct 29, 2023
I'm taking a look at this now, so I don't mind picking it up sine I'm fixing it for my project anyways. (Inspector Caracal also mentioned writing unit tests for these - I will look to see what's needed there.)
Griatch
removed
the
needs-triage
Yet to be looked at and verified as an a real issue/feature that could be worked on
label
Nov 26, 2023
@scyfris I fixed the trivial kwargs.get issue; the pickling of session is an interesting one - pickling happens for data sent over AMP between server and portal, and which is why this error happens on the .msg call. The reason the Session is not pickle-able is likely because it 'hides' database-tied objects 'inside' it. Easiest for this use case is likely to convert the Session to a string representation since its not used per-se on the portal side.
Describe the bug
Right now, monitor and monitored INPUT_FUNS seem to be broken.
There are two errors with the monitore-related functiosn in inputfuncs.py:
Needs to be
This throws the error:
Looking into a bit more, it seems the the call
returns a list of things that can't all be pickleable , in particular the 'session' entry . An example of a call would be below:
Changing that to:
Works fine.
Note sure the proper fix yet - just logging here for now.
To Reproduce
Use any client and test with the following:
For the monitored issue, just send a "monitored" command after monitoring some value from the client. THIS REQUIRES A FIX TO THE ABOVE FIRST! You will see an error in logs/server.log indicated earlier in this bug.
Expected behavior
Things should work without python errors .
Environment, Evennia version, OS etc
NOTE: I am using a custom client , but I'm not doing anything custom about these INPUT_FUNCS.
The text was updated successfully, but these errors were encountered: