Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wasm-opt mandatory for Releases #39

Open
holgerd77 opened this issue Mar 21, 2024 · 0 comments
Open

Make wasm-opt mandatory for Releases #39

holgerd77 opened this issue Mar 21, 2024 · 0 comments

Comments

@holgerd77
Copy link
Member

The wasm-opt Rust package is marked as optional - see here in the Rust build script - and build is also running if the package is not installed.

This is suboptimal since this bears the risk of doing releases without the optimization step. This should especially be avoided since - if we merge things to master on the monorepo side, this library will get published within the realm of our normal library stack.

So we should either make this mandatory by default in general or alternatively add a check later in the pipeline (when doing releases e.g., with a pre-publish hook or something?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant