CI should run cargo build

[axic]

It will need to have access to rust, cargo and emscripten in the CI.

One can use the circleci files from https://github.com/ewasm/ewasm-precompiles or https://github.com/ewasm/ewasm-rust-api

The CI should:

• run rustfmt
• run cargo build
• and run emscripten build (aka the makefile)

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Foundation fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $45,589.90 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Workers have applied to start work.

These users each claimed they can complete the work by 4 months ago.
Please review their action plans below:

1) abitrolly has applied to start work (Funders only: approve worker | reject worker).

Spent an hour - half way done - #36 - reading on Emscripten https://rustwasm.github.io/book/

Learn more on the Gitcoin Issue Details page.

[tpscrpt]

@axic I'm guessing the emcc binary is required, even in the CI build; which means you don't mind if it takes a little bit to run on cache miss? Might be a good idea to have the CI build run install emcc first. Working on testing the circle.yml now and will update you with progress (I do understand I'm not yet approved).

EDIT: Custom Dockerfile it is!

[spm32]

Hi @JeremiGendron how is this going?

[tpscrpt]

I tried very hard, unfortunately I was getting issue with settings up the environment to properly run everything.

…

On Fri, Feb 8, 2019 at 12:36 PM Scott Moore ***@***.***> wrote: Hi @JeremiGendron <https://github.com/JeremiGendron> how is this going? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWfqZXIdPWGFRsElBXeCeViJ6Y4ghHMWks5vLbWYgaJpZM4VR9xt> .

[abitrolly]

@axic I made Travis CI run the commands you specified - check out #36.

The incoming version of Emscripten SDK takes ages to compile as promised. latest on the other side is installed from binaries. I opened issue emscripten-core/emscripten#8045 but there is nothing more that could be done.

PR #36 makes CI running as requested along with cleanups. I can not fix Travis build time or make rustbn.js run on stable Emscripten. https://travis-ci.org/ethereumjs/rustbn.js/jobs/490897289#L632 for this bounty.

[Anish-Agnihotri]

Hey folks, it looks like this issue was dropped, and has expired as well. I'm retracing the conversation and it looks like it was left with an open PR implementing a historic version of CircleCI due to breaking changes.

If there is still a demand for this, I'd be more than happy to pick up the bounty and take a shot at it.

[abitrolly]

Hi Anish. The problem is that compilation is failing and no one knows why. I opened #39 You can help troubleshooting that by repeating the build manually yourself.

[xiaods]

hi @axic i see you submit a pr to fix #39 , why not do some merge on it ? it will block @abitrolly 's pr.

i have testing on the PR#38, found a error came from Makefile:

	@res=$$(sed -n '/run()$$/p' lib/index.asm.js | wc -l); \
	if [ $$res == "0" ]; then \
		echo "ERROR: could not find run() function in generated code"; \
		exit 1; \
	fi\

in latest asm.js, it have no run() function. i don't know relate this function more infos.

[xiaods]

@axic i follow the README example, use node to load lib/index.asm.js, but i can't invoke the add func.

[abitrolly]

@axic #36 is now green and this issue can be closed.