Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests to achieve 100% coverage #26

Open
axic opened this issue Feb 3, 2018 · 5 comments
Open

Create tests to achieve 100% coverage #26

axic opened this issue Feb 3, 2018 · 5 comments

Comments

@axic
Copy link
Member

axic commented Feb 3, 2018

A couple of simple tests can be added to cover index.js (except the fromV1 function). Covering thirdparty.js is secondary.

@holgerd77
Copy link
Member

Not sure if I find some time but if so would it be ok to directly push some additional tests to the dependency-update PR #25?

@axic
Copy link
Member Author

axic commented Feb 7, 2018

I'd create a new PR off that. Want to merge #25 once ethereumjs-util 5.1.4 is released.

@stvtortora
Copy link

Hey, do you still need help with this issue? I'd bee happy to take it.

@alcuadrado
Copy link
Member

Hey @stvtortora! Help on this would be great!

According to coveralls, the third party module is the least tested. It contains utility functions to encode/decode wallets generated by different apps.

Let me know if you need help with this.

@holgerd77
Copy link
Member

Hi @stvtortora that's nice, thanks for the offer! 😄 Please be aware of this open PR #86 from @chikeichan. We forgot a bit about that unfortunately, but would be nice if we would get this updated and merged along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants