Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fit ~20% more data into each utp packet #910

Open
carver opened this issue Sep 13, 2023 · 1 comment
Open

perf: fit ~20% more data into each utp packet #910

carver opened this issue Sep 13, 2023 · 1 comment
Labels
shelf-stable Will not be closed by stale-bot

Comments

@carver
Copy link
Collaborator

carver commented Sep 13, 2023

See a discussion of how high the max_packet_size could go:
#767 (comment)

Here is some discussion internal to discv5, with an example of calculating a max packet size:
https://github.com/sigp/discv5/blob/d2e30e04ee62418b9e57278cee907c02b99d5bd1/src/service.rs#L1054-L1067

Another fairly reasonable approach to this would be to set the packet size too high on a local build, and look out for this warning log:
https://github.com/sigp/discv5/blob/d2e30e04ee62418b9e57278cee907c02b99d5bd1/src/socket/send.rs#L67-L68

Then we can reduce the max size to not trigger that warning.


All of this work will probably have a limited lifetime, since we plan to switch to use this at some point: ethereum/devp2p#229

Copy link
Contributor

This issue is stale because it has been open for 180 days with no activity.

@github-actions github-actions bot added the stale label Mar 12, 2024
@njgheorghita njgheorghita added shelf-stable Will not be closed by stale-bot and removed stale labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shelf-stable Will not be closed by stale-bot
Projects
None yet
Development

No branches or pull requests

2 participants