Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3_clientVersion displays trin-utils version #878

Open
ogenev opened this issue Aug 31, 2023 · 1 comment
Open

web3_clientVersion displays trin-utils version #878

ogenev opened this issue Aug 31, 2023 · 1 comment
Labels
bug Something isn't working good-community-issue

Comments

@ogenev
Copy link
Member

ogenev commented Aug 31, 2023

When we want to get the client version, we use the CARGO_PKG_VERSION env variable to display the version metadata from the Cargo.toml file.

pub const TRIN_VERSION: &str = env!("CARGO_PKG_VERSION");

This is fine as long as we call the env from the correct package 😸 .
In the example above, CARGO_PKG_VERSION returns the version of the trin-utils package, not the version of the trin package.
So any changes made to trin/Cargo.toml version have no effect on the web3_clientVersion endpoint.

@ogenev ogenev added bug Something isn't working flamingo Maintenance or downtime for the person on Flamingo rotation to tackle good-community-issue and removed flamingo Maintenance or downtime for the person on Flamingo rotation to tackle labels Aug 31, 2023
@AmirH-A
Copy link
Contributor

AmirH-A commented May 23, 2024

This problem has been solved, if you think it is advisable to close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-community-issue
Projects
None yet
Development

No branches or pull requests

2 participants