Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport renaming _created_accounts from cancun to older forks #927

Open
SamWilsn opened this issue Apr 11, 2024 · 0 comments · May be fixed by #930
Open

Backport renaming _created_accounts from cancun to older forks #927

SamWilsn opened this issue Apr 11, 2024 · 0 comments · May be fixed by #930
Assignees
@gurukamath
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Milestone
Post-Cancun Refac...

Comments

@SamWilsn
Copy link
Collaborator

Renamed in Cancun:

execution-specs/src/ethereum/cancun/state.py

Line 47 in dbf213b

created_accounts: Set[Address] = field(default_factory=set)

To minimize spurious diffs between forks, this should be backported.
@SamWilsn SamWilsn added A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers labels Apr 11, 2024
@SamWilsn SamWilsn added this to the Post-Cancun Refactoring milestone Apr 11, 2024
@gurukamath gurukamath self-assigned this Apr 15, 2024
@gurukamath gurukamath linked a pull request Apr 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gurukamath gurukamath

Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Projects
None yet
Milestone
Post-Cancun Refactoring
Development

Successfully merging a pull request may close this issue.

Backport stuff post cancun gurukamath/execution-specs
2 participants
@gurukamath @SamWilsn