Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move includability checks from process_transaction() to check_transaction() #799

Open
petertdavies opened this issue Jul 4, 2023 · 1 comment
Assignees
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty

Comments

@petertdavies
Copy link
Collaborator

Checks about whether a transaction is includable should be done in check_transaction(), but some of them are in process_transaction(). For example:

ensure(sender_account.nonce == tx.nonce, InvalidBlock)
ensure(sender_account.balance >= gas_fee + tx.value, InvalidBlock)
ensure(sender_account.code == bytearray(), InvalidBlock)

These checks should be identified and moved to check_transaction().

@SamWilsn SamWilsn added this to the Post-Cancun Refactoring milestone Feb 1, 2024
@SamWilsn SamWilsn added A-spec Area: specification C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty labels Feb 1, 2024
@gurukamath gurukamath self-assigned this Apr 16, 2024
@gurukamath
Copy link
Collaborator

The checks have been moved for cancun and will need to be back ported to the older forks before closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-medium Experience: of moderate difficulty
Projects
None yet
Development

No branches or pull requests

3 participants