Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_fixtures function does not check for the fixtures version #728

Open
gurukamath opened this issue Mar 17, 2023 · 0 comments
Open
Labels
C-bug Category: this is a bug, deviation, or other problem. E-medium Experience: of moderate difficulty

Comments

@gurukamath
Copy link
Collaborator

See download_fixtures

Currently, the testing framework downloads the json fixtures as and when needed. There are two methods for this - 1. using git clone 2. download raw fixtures (using the download_fixtures function)

While the former checks out the appropriate version of the fixtures, the latter does not. The download_fixtures only checks if the fixtures folder is available. This could lead to issues if the fixture version has been changed or the downloaded fixtures have been corrupted in some way.

At the same time, it might not be optimal to download the fixtures everytime, even when the correct fixtures are already present from a previous run. Some middle ground has to be worked out here.

@gurukamath gurukamath added C-bug Category: this is a bug, deviation, or other problem. E-medium Experience: of moderate difficulty labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: this is a bug, deviation, or other problem. E-medium Experience: of moderate difficulty
Projects
None yet
Development

No branches or pull requests

1 participant